Bug 488197
Summary: | Review Request: ibus-rawcode - The Rawcode engine for IBus | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pravin Satpute <psatpute> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-04 04:39:54 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Pravin Satpute
2009-03-03 06:11:02 UTC
you need to BR: ibus-devel as well as need to modify configure.ac to change package requirement from ibus-1.0 to ibus-1.1 Also, change %define to %global in spec. oops looks like ibus-devel-1.1.0.20090225-1.fc11 in rawhide provides ibus-1.0 not ibus-1.1 remove %define as it was not require for ibus-rawcode added BuildRequires: ibus-devel new url Spec URL: http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode.spec SRPM URL: http://pravins.fedorapeople.org/ibus-rawcode/ibus-rawcode-1.0.0.20090303-2.fc11.src.rpm Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216185 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 26e7aeb1e54ebbab4de222f67ffe174f ibus-rawcode-1.0.0.20090303.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package ibus-rawcode-1.0.0.20090303-2.fc11-i586 => Requires: Requires: libc.so.6 libc.so.6(GLIBC_2.0) libdbus-1.so.3 libglib-2.0.so.0 libgobject-2.0.so.0 libibus.so.0 rtld(GNU_HASH) Provides: ibus-rawcode = 1.0.0.20090303-2.fc11 APPROVED. New Package CVS Request ======================= Package Name: ibus-rawcode Short Description: The Rawcode input engine for IBus platform Owners: pravins Branches: devel InitialCC: Cvsextras Commits: yes cvs done. completed build Thanks Parag and Kevin |