Bug 488444

Summary:	Review Request: perl-MooseX-Singleton - Turn your Moose class into a singleton
Product:	[Fedora] Fedora	Reporter:	Allisson Azevedo <allisson>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-05 21:48:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Allisson Azevedo 2009-03-04 12:10:39 UTC

Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Singleton/perl-MooseX-Singleton.spec

SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Singleton/perl-MooseX-Singleton-0.14-1.fc10.src.rpm

Description: A singleton is a class that has only one instance in an application.
MooseX::Singleton lets you easily upgrade (or downgrade, as it were) your
Moose class to a singleton.

Comment 1 Parag AN(पराग) 2009-03-04 13:18:20 UTC

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1219852
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2e1aefa342d4d73bd8ff6fe2ab0ab34e  MooseX-Singleton-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=42,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.34 cusr  0.07 csys =  1.45 CPU)
+ Package perl-MooseX-Singleton-0.14-1.fc11-noarch =>
Provides: perl(MooseX::Singleton) = 0.14 perl(MooseX::Singleton::Meta::Class) perl(MooseX::Singleton::Meta::Instance) perl(MooseX::Singleton::Meta::Method::Constructor) perl(MooseX::Singleton::Object)
Requires: perl(Moose) perl(Moose::Exporter) perl(Scalar::Util) perl(metaclass)

APPROVED.

Comment 2 Allisson Azevedo 2009-03-04 13:28:20 UTC

New Package CVS Request
=======================
Package Name: perl-MooseX-Singleton
Short Description: Turn your Moose class into a singleton
Owners: allisson
Branches: F-9 F-10
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-03-05 20:43:59 UTC

cvs done.