Bug 488927
| Summary: | [PATCH] Handle errors from tools called properly (& fix an off by one error) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> | ||||
| Component: | system-config-kdump | Assignee: | Roman Rakus <rrakus> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | dlehman, rrakus, tsmetana | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-04-27 13:13:59 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
When applying the patch, please remove these: + print self.kdumpMem + print origKdumpMem Ping? Thanks for patch. s-c-kdump is being reworked. Your patch for "Handle errors from tools called properly" don't fit well to newer scheme with PolicyKit and dbus. The fix an off by one error is now in upstream and I will add it to rawhide soon. Off by one error fixed in system-config-kdump-1.0.14-5.fc11 This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. (In reply to comment #3) > s-c-kdump is being reworked. > Your patch for "Handle errors from tools called properly" don't fit well to > newer scheme with PolicyKit and dbus. Development freeze is coming really close and rawhide package is not based on the new codebase. I applied the patch; there's no harm in having it there. I'll look into possibility of adjusting it to new codebase later on; keeping this open. This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping This message is a reminder that Fedora 11 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 11. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '11'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 11's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 11 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Already fixed |
Created attachment 334269 [details] Handle errors from tools called properly (& fix an off by one error) Patch attached. Display an action progressbar while reconfiguring the boot loader and generating the ram disk image. Handle errors and display diagnostic information in case an error occur. Apart from that it fixes an off-by-one error in kernel cmdline parsing code, (third hunk) which prevented from system-config-kdump from running successfully on systems with crash kernel offset already being in effect. (Broken by system-config-kdump-1.0.14-ommit-offset.patch)