Bug 489676

This fails to build for me.  The %check section fails:

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
Can't locate Test/More.pm in @INC (@INC contains: /builddir/build/BUILD/XML-Simple-DTDReader-0.04/blib/lib /builddir/build/BUILD/XML-Simple-DTDReader-0.04/blib/arch /usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/5.10.0 /usr/local/lib64/perl5/site_perl/5.10.0/x86_64-linux-thread-multi /usr/local/lib/perl5/site_perl/5.10.0 /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.10.0 /usr/lib/perl5/vendor_perl /usr/lib/perl5/site_perl .) at t/1.t line 1.
BEGIN failed--compilation aborted at t/1.t line 1.
t/1.t ..
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run

This indicates missing build dependencies.

How embarrassing... I could have swear I've built it into mock.

Fixed package :
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-XML-Simple-DTDReader.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-XML-Simple-DTDReader-0.04-2.fc10.src.rpm

Thanks.  It boulds now, and looks OK except for one problem:

The dependency on XML::Parser is doubled.  rpm finds an unversioned dependency by itself, but the spec has a manual versioned one.  All supported Fedora releases shipped with XML::Parser 2.36 or later, so there shouldn't be a need for a explicit versioned dependency and you should be able to just drop it.  However, if you really want to keep it, you'll need to filter the automatic one.

* source files match upstream.  sha256sum:
   00335c6817f7a76c034183b4fc25effae7f00ba0d8ac86ab418f60d2cce4d224  
   XML-Simple-DTDReader-0.04.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(XML::Simple::DTDReader) = 0.04
   perl-XML-Simple-DTDReader = 0.04-2.fc11
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(Carp)
   perl(Cwd)
   perl(Data::Dumper)
   perl(Exporter)
   perl(File::Basename)
X  perl(XML::Parser)
   perl(XML::Parser) >= 2.28
   perl(strict)
   perl(vars)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=20,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.17 cusr  0.03 
    csys =  0.23 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

I've removed the explicit R: from the spec.
Fixed package :
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-XML-Simple-DTDReader.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-XML-Simple-DTDReader-0.04-3.fc10.src.rpm  

Thanks for the review, Jason.

Looks good, thanks.

APPROVED

New Package CVS Request
=======================
Package Name: perl-XML-Simple-DTDReader
Short Description: Simple XML file reading based on their DTDs
Owners: xavierb
Branches: F-9 F-10 EL-4 EL-5
InitialCC: perl-sig

cvs done.

perl-XML-Simple-DTDReader-0.04-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/perl-XML-Simple-DTDReader-0.04-3.fc9

perl-XML-Simple-DTDReader-0.04-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-XML-Simple-DTDReader-0.04-3.fc10

perl-XML-Simple-DTDReader-0.04-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

perl-XML-Simple-DTDReader-0.04-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.