Bug 489744

Summary: Regression in sudo since --secure-path was enabled
Product: [Fedora] Fedora Reporter: Jeff Schroeder <jeffschroeder>
Component: sudoAssignee: Daniel Kopeček <dkopecek>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 11CC: dkopecek, kzak, pvrabec
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.7.1-1.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-16 01:57:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jeff Schroeder 2009-03-11 16:28:08 UTC
Description of problem:
Our users have a pretty scary PATH variable and they have a script named runasrelease that does:
sudo -u release bash -c "$*"

Since upgrading to fedora10+, the PATH variable is cleared and set to whatever was builtin with --secure-path. This breaks our expected usage of sudo as it removes PATH which we want set.

Adding:
!env_reset

or env_reset
env_keep = "HOME PATH"

does not work.

Version-Release number of selected component (if applicable):
sudo-1.6.9p17-6

How reproducible:
PATH=$PATH:/tmp/pathtest
sudo -u anyotheruser bash -c 'echo $PATH'

Steps to Reproduce:
jschroeder: ~ $ echo $PATH
/usr/local/bin:/bin:/usr/bin:/usr/X11R6/bin:/usr/java/bin:/home/release:/home/release/scripts:/opt/mysql/5.1.30/bin:/home/jschroeder/bin
jschroeder: ~ $ sudo -u release bash -c 'echo $PATH'
[sudo] password for jschroeder: 
/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin

Actual results:
PATH is cleared due to the --secure-path option

Expected results:
There should be a way for PATH to not be cleared. !env_reset or adding PATH to env_keep should work. This is fixed in 1.7.0 according to upstream.

Additional info:

* Wed May 14 2008 Peter Vrabec <pvrabec> 1.6.9p13-6
- compiled with secure path (#80215)

https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/192651 ubuntu bug
http://www.gratisoft.us/bugzilla/show_bug.cgi?id=284 upstream bug

Comment 1 Fedora Update System 2009-05-12 12:07:41 UTC
sudo-1.7.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/sudo-1.7.1-1.fc11

Comment 2 Fedora Update System 2009-05-13 00:23:37 UTC
sudo-1.7.1-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sudo'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4879

Comment 3 Bug Zapper 2009-06-09 12:08:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Fedora Update System 2009-06-16 01:57:40 UTC
sudo-1.7.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.