Bug 490028

Summary:	Review Request: pytc - Python bindings for Tokyo Cabinet
Product:	[Fedora] Fedora	Reporter:	Silas Sewell <silas>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, silas
Target Milestone:	---	Flags:	mtasaka: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-31 07:39:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Silas Sewell 2009-03-12 21:20:38 UTC

Spec URL:
http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/python-tokyocabinet/python-tokyocabinet.spec
SRPM URL:
http://silassewell.googlecode.com/files/python-tokyocabinet-0.7-1.src.rpm
Description: 
Python bindings for Tokyo Cabinet.

I'll need a sponsor.

Comment 1 Mamoru TASAKA 2009-03-23 15:44:05 UTC

Some notes:

* %define -> %global
  - Now Fedora suggests to use %global instead of %define, especially
    for the nested macro definition. ref:
    https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
    https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define
    (The latter one says "Draft", however it is already accepted by
    FESCo).

* Naming
  - Fedora prefers to use the tarball name as rpm name as
    much as possible. For this package I recommend to use
    "pytc" as rpm name.

* Requires
----------------------------------------------------------
Requires:       python >= 2.3
Requires:       tokyocabinet
----------------------------------------------------------
  - Both of these are unnecessary. These dependencies are
    automatically pulled in by libraries' dependencies
    caught by rpmbuild itself.

Comment 2 Silas Sewell 2009-03-27 04:49:54 UTC

Thanks Mamoru!

SRPM: http://silassewell.googlecode.com/files/pytc-0.7-2.fc10.src.rpm

SPEC: http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/pytc/pytc.spec

Diff: http://code.google.com/p/silassewell/source/diff?spec=svn192&r=192&format=side&path=/trunk/projects/packages/rpms/pytc/pytc.spec

Comment 3 Mamoru TASAKA 2009-03-27 15:22:58 UTC

This one can be accepted.

---------------------------------------------------
  This package (pytc) is APPROVED by mtasaka
---------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
After you request for sponsorship a mail will be sent to sponsor 
members automatically (which is invisible for you) which notifies 
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 9/10, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Comment 4 Silas Sewell 2009-03-27 15:45:00 UTC

Thanks Mamoru, I have requested sponsorship and my FAS username is "silas".

Comment 5 Mamoru TASAKA 2009-03-27 16:01:14 UTC

Okay, now I am sponsoring you. Please follow "Join" wiki
again.

Comment 6 Silas Sewell 2009-03-28 06:11:00 UTC

New Package CVS Request
=======================
Package Name: pytc
Short Description: Tokyo Cabinet Python bindings
Owners: silas
Branches: 
InitialCC:

Comment 7 Kevin Fenzi 2009-03-30 21:50:03 UTC

cvs done.

Comment 8 Silas Sewell 2009-03-31 07:39:36 UTC

Build for F-11, closing.

Thanks Mamoru and Kevin.