Bug 490207

Summary: Wrong Ok/Cancel button order in virt-manager cd-rom connect dialog
Product: [Fedora] Fedora Reporter: Michael Monreal <michael.monreal>
Component: virt-managerAssignee: Daniel Berrangé <berrange>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: berrange, crobinso, hbrock, markmc, quintela, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-13 14:19:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 480594    
Attachments:
Description Flags
Screenshot none

Description Michael Monreal 2009-03-13 20:08:28 UTC 
The CD source dialog uses the wrong order of buttons: Ok, Cancel

It should be Cancel, Ok (as with other GTK/GNOME apps). Also, "OK" should better be "Close" as per GNOME HIG.
Comment 1 Michael Monreal 2009-03-13 20:13:53 UTC 
Created attachment 335154 [details]
Screenshot
Comment 2 Mark McLoughlin 2009-03-25 17:18:25 UTC 
Confirmed in virt-manager-0.7.0-1.fc11.x86_64, should be an easy fix

(This is the CD-ROM "connect" dialog)
Comment 3 Cole Robinson 2009-04-06 15:44:03 UTC 
Fixed upstream:

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/6f0170f9d551

Moving to POST.
Comment 4 Cole Robinson 2009-04-13 14:19:11 UTC 
This should be in 0.7.0-3.fc11, closing as RAWHIDE.