Bug 490254

Summary: IL_LBM changed to IL_ILBM without any notice?
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: DevILAssignee: Hans de Goede <hdegoede>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: hdegoede
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-14 11:10:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 486390    

Description Mamoru TASAKA 2009-03-14 07:52:17 UTC 
Description of problem:
Now I am trying to review bug 486390, but it does
not compile on dist-f11 like:
-----------------------------------------------------------
In file included from /builddir/build/BUILD/simspark-0.1/lib/kerosin/imageserver/imageserver.cpp:22:
/builddir/build/BUILD/simspark-0.1/lib/kerosin/imageserver/imageserver.h:69: error: 'IL_LBM' was not declared in this scope
-----------------------------------------------------------
It does compile on dist-f10-updates-candidate.

IL_LBM was defined in IL/il.h of DevIL 1.7.5/1.7.7, however
it seems that this was changed to IL_ILBM without any notice.
- Is this intentional or by accident?
- Also generally is such change allowed?

Version-Release number of selected component (if applicable):
DevIL-1.7.8-1.fc11

How reproducible:
100%

Steps to Reproduce:
1. See above
2.
3.
Comment 1 Hans de Goede 2009-03-14 11:10:38 UTC 
This is an API change not an ABI change, so it doesn't cause any runtime issues
only build issues. And I expect most programs to not use this define.

Moreover this is an upstream API change which is annoying, but pretty trivial to
fix when hit. There is not a whole lot I can do here, as I do not want to diverge
from upstream in this.