Bug 490441

Summary: Review Request: hyphen-mn - Mongolian hyphenation rules
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-03-17 10:05:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2009-03-16 13:08:39 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-mn.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-mn-0.20090315-1.fc10.src.rpm
Description: Mongolian hyphenation rules as usable by OpenOffice.org

Comment 1 Parag AN(पराग) 2009-03-16 13:28:54 UTC
Review:
+ package builds in mock (rawhide).
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1243665
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6fbef99fdcf60e42781d1a54774d8efa  hyph-mn-cyrl-x-2a.tex
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

 APPROVED.

Comment 2 Caolan McNamara 2009-03-16 13:58:22 UTC
New Package CVS Request
=======================
Package Name: hyphen-mn
Short Description: Mongolian hyphenation rules
Owners: caolanm
Branches: devel
InitialCC:

Comment 3 Kevin Fenzi 2009-03-17 05:25:54 UTC
cvs done.