Bug 490562

Here is a finished Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1242743

Reviewing.

Looking at your first package RR, you are already sponsored. Removing FE-NEEDSPONSOR.

A few initial notes:

- the URL
URL:		http://www.nongnu.org/%{name}
would be better as
URL:		http://www.nongnu.org/renameutils

since that way you can open the link straight away from the spec file (you don't have to expand the macro yourself).

- Remove
Requires: readline
as this is picked up automatically by rpmbuild.

- Locales are not handled correctly, see
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

After you've fixed these I'll make the full review.

Also, as you are a new packager you should make a habit of running rpmlint on all your packages and paste the output in the Review Request every time you put in a new release (up to the package being accepted, that is).

(In reply to comment #3)
> A few initial notes:
> 
> - the URL
> URL:  http://www.nongnu.org/%{name}
> would be better as
> URL:  http://www.nongnu.org/renameutils
> 
> since that way you can open the link straight away from the spec file (you
> don't have to expand the macro yourself).

Fixed.

> - Remove
> Requires: readline
> as this is picked up automatically by rpmbuild.

Done.

> - Locales are not handled correctly, see
> http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

Done: http://plouj.com/rpmbuild/SPECS/renameutils.spec and http://plouj.com/rpmbuild/SRPMS/renameutils-0.10.0-1.fc9.src.rpm .

> After you've fixed these I'll make the full review.
> 
> Also, as you are a new packager you should make a habit of running rpmlint on
> all your packages and paste the output in the Review Request every time you put
> in a new release (up to the package being accepted, that is).  

I'll do that. The only reason I didn't do it is because https://fedoraproject.org/wiki/Package_Review_Process didn't mention it. However, for my package rpmlint (0.85) doesn't print any errors/warnings:

$ rpmlint /home/plouj/rpmbuild/RPMS/x86_64/renameutils-0.10.0-1.fc9.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /home/plouj/rpmbuild/RPMS/x86_64/renameutils-debuginfo-0.10.0-1.fc9.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /home/plouj/rpmbuild/SRPMS/renameutils-0.10.0-1.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

(In reply to comment #4)
> (In reply to comment #3)
> > Also, as you are a new packager you should make a habit of running rpmlint on
> > all your packages and paste the output in the Review Request every time you put
> > in a new release (up to the package being accepted, that is).  
> 
> I'll do that. The only reason I didn't do it is because
> https://fedoraproject.org/wiki/Package_Review_Process didn't mention it.
> However, for my package rpmlint (0.85) doesn't print any errors/warnings:

Yeah, but it's nicer for the reviewer that way :)

- You should increment the release number every time you make a new release, and add a short comment about the changes you've done to the changelog. This applies also during the review process.

- Installation does not preserve time stamps. Change
 make install DESTDIR=$RPM_BUILD_ROOT
to:
 make install INSTALL="install -p" DESTDIR=$RPM_BUILD_ROOT

- AUTHORS and ChangeLog are missing from documentation.

After these changes the package is good to go.

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Also, as you are a new packager you should make a habit of running rpmlint on
> > > all your packages and paste the output in the Review Request every time you put
> > > in a new release (up to the package being accepted, that is).  
> > 
> > I'll do that. The only reason I didn't do it is because
> > https://fedoraproject.org/wiki/Package_Review_Process didn't mention it.
> > However, for my package rpmlint (0.85) doesn't print any errors/warnings:
> 
> Yeah, but it's nicer for the reviewer that way :)

Should this be mentioned on the wiki?

> - You should increment the release number every time you make a new release,
> and add a short comment about the changes you've done to the changelog. This
> applies also during the review process.
> 
> - Installation does not preserve time stamps. Change
>  make install DESTDIR=$RPM_BUILD_ROOT
> to:
>  make install INSTALL="install -p" DESTDIR=$RPM_BUILD_ROOT

Fixed.

> - AUTHORS and ChangeLog are missing from documentation.

ChangeLog mentions that it obsoleted by NEWS and it seems so based on content. I just added AUTHORS.

http://plouj.com/rpmbuild/SPECS/renameutils.spec has been updated and http://plouj.com/rpmbuild/SRPMS/renameutils-0.10.0-2.fc9.src.rpm has been uploaded.

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #3)
> > > > Also, as you are a new packager you should make a habit of running rpmlint on
> > > > all your packages and paste the output in the Review Request every time you put
> > > > in a new release (up to the package being accepted, that is).  
> > > 
> > > I'll do that. The only reason I didn't do it is because
> > > https://fedoraproject.org/wiki/Package_Review_Process didn't mention it.
> > > However, for my package rpmlint (0.85) doesn't print any errors/warnings:
> > 
> > Yeah, but it's nicer for the reviewer that way :)
> 
> Should this be mentioned on the wiki?

Uhh, maybe. The reason why it stands at it does now is probably that the reviewer must in any case run rpmlint on the generated packages. It's just good practice for the packager to check whether s/he has got everything right before submitting the package for critisism.

> > - AUTHORS and ChangeLog are missing from documentation.
> 
> ChangeLog mentions that it obsoleted by NEWS and it seems so based on content.
> I just added AUTHORS.

OK.

- Change the summary to "A set of programs to make renaming and copying of files easier". The current summary is inexact since the package is not purely about moving, but also copying files. You can do this upon import to CVS (remember to increment the release, still :)

*****

rpmlint output is clean. The package adheres to Fedora Packaging and Package Review Guidelines and is thus APPROVED.

New Package CVS Request
=======================
Package Name: renameutils
Short Description: A set of programs to make renaming and copying of files easier
Owners: plouj 
Branches: F-9 F-10
InitialCC:

cvs done.

renameutils-0.10.0-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/renameutils-0.10.0-3.fc9

renameutils-0.10.0-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/renameutils-0.10.0-3.fc10

renameutils-0.10.0-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

renameutils-0.10.0-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.