Bug 490578 (mod_perlite)
Summary: | Review Request: mod_perlite - Kinder, gentler embedded Perl for the Apache HTTP Server | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, iarnell, notting, panemade |
Target Milestone: | --- | Flags: | iarnell:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://modperlite.org | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-04-11 05:12:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Chris Weyl
2009-03-17 03:30:37 UTC
in build.log I see cp: cannot create regular file `/usr/lib/httpd/modules/mod_perlite.so': Permission denied apxs:Error: Command failed with rc=65536 . That's expected -- AFAICT the Build.PL isn't smart enough to install mod_perlite.so under our %buildroot. ./Build install handles *.pm correctly, then mod_perlite.so is handled manually a couple lines down. - source files match upstream. I can't verify - this looks like a manual tar of a local tree complete with entire .git directory. Would be better to use git-archive and add a comment with the exact command(s) used to recreate it + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license (GPL+ or Artistic). + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock (https://koji.fedoraproject.org/koji/taskinfo?taskID=1286552). + package installs properly. + debuginfo package looks complete. + rpmlint has no complaints: mod_perlite.src: I: checking mod_perlite.x86_64: I: checking mod_perlite-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: config(mod_perlite) = 0.09-0.1.git20090314.fc11 mod_perlite.so()(64bit) perl(Perlite) perl(Perlite::ConfigData) perl(Perlite::IO) mod_perlite = 0.09-0.1.git20090314.fc11 mod_perlite(x86-64) = 0.09-0.1.git20090314.fc11 = config(mod_perlite) = 0.09-0.1.git20090314.fc11 httpd-mmn = 20051115 ld-linux-x86-64.so.2()(64bit) ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libperl.so()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libresolv.so.2()(64bit) libutil.so.1()(64bit) perl(:MODULE_COMPAT_5.10.0) perl(:WITH_PERLIO) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) + %check is present and all tests pass. + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED assuming you'll make Source0 a little cleaner. (In reply to comment #3) > - source files match upstream. > I can't verify - this looks like a manual tar of a local tree complete with > entire .git directory. Would be better to use git-archive and add a comment > with the exact command(s) used to recreate it Will do :) New Package CVS Request ======================= Package Name: mod_perlite Short Description: Kinder, gentler embedded Perl for the Apache HTTP Server Owners: cweyl Branches: F-9 F-10 devel InitialCC: cvs done. Thanks for the review! :-) |