Bug 490580
| Summary: | Review Request: faust - Compiled language for real-time audio signal processing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> | ||||
| Component: | Package Review | Assignee: | Conrad Meyer <cse.cem+redhatbugz> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | cse.cem+redhatbugz, fedora-package-review, notting | ||||
| Target Milestone: | --- | Flags: | cse.cem+redhatbugz:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.9.9.4-2.b.fc10 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-04-09 16:16:03 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Orcan Ogetbil
2009-03-17 04:05:42 UTC
Created attachment 336130 [details]
[Review]
Attached is my initial review.
Summary:
- rpmlint: only-non-binary-in-usr-lib should be explained or fixed
- should tools/%{name}2pd-* be %doc?
- is the doc subpackage not requiring the base package intentional?
(In reply to comment #1) > Created an attachment (id=336130) [details] > [Review] > > Attached is my initial review. > Thank you for the initial review! > Summary: > - rpmlint: only-non-binary-in-usr-lib should be explained or fixed I fixed this. I put all those files in %{_datadir}/%{name} > - should tools/%{name}2pd-* be %doc? pd (Pure Data: http://puredata.info/) is a large programming environment that is unfortunately not packaged in Fedora yet. Thus installing these files in %{_bindir} will not mean much for the time being (We could even build these files from sources if we had pd in Fedora.). I am thinking of keeping these in %doc until the day we have pd packaged (which is no easy task). > - is the doc subpackage not requiring the base package intentional? Yes that was intentional. I checked the existing doc subpackages we have in Fedora. Some require the main package, some don't. On a second thought, I couldn't think of a case where someone would just want the doc subpackage for faust without needing the main package, so I added the dep. So here we are: Spec URL: http://oget.fedorapeople.org/review/faust.spec SRPM URL: http://oget.fedorapeople.org/review/faust-0.9.9.4-2.b.fc10.src.rpm Changelog: 0.9.9.4-2.b - Fix the year of the previous changelog entry - Install the nonbinary files in %%{_datadir}/%%{name}/ - Add Requires: %%{name}=%%{version}-%%{release} to the doc subpackage This looks very good, thank you for packaging it for Fedora. APPROVED. I thank you for the review! New Package CVS Request ======================= Package Name: faust Short Description: Compiled language for real-time audio signal processing Owners: oget Branches: F-10 InitialCC: cvs done. faust-0.9.9.4-2.b.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/faust-0.9.9.4-2.b.fc10 faust-0.9.9.4-2.b.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update faust'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2935 faust-0.9.9.4-2.b.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |