|Summary:||bug-buddy (gnome-breakpad) ignores build-id debuginfo|
|Product:||[Fedora] Fedora||Reporter:||Will Woods <wwoods>|
|Component:||bug-buddy||Assignee:||Ray Strode [halfline] <rstrode>|
|Status:||CLOSED RAWHIDE||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2009-04-05 04:46:18 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Bug Depends On:|
|Bug Blocks:||334811, 446451|
Description Will Woods 2009-03-17 23:06:46 UTC
Created attachment 335617 [details] build-id patch against bug-buddy 2.26.0 When a program crashes bug-buddy checks to see if debuginfo is available before attempting a gdb backtrace. Unfortunately it only checks for embedded debuginfo and debuginfo specified by an ELF .gnu_debuglink section - it doesn't know about the GNU_BUILD_ID note. The attached patch enhances elf_has_debug_symbols() to check for GNU_BUILD_ID debuginfo files as well. This is required for using bug-buddy with debuginfofs (see http://fedoraproject.org/wiki/Features/DebuginfoFS for details). Patch is against bug-buddy-2.26.0 - I haven't attempted to apply it to any earlier versions. I should probably push this upstream, once I figure out if the gdb build-id support is present in upstream gdb.
Comment 1 Matthias Clasen 2009-03-18 01:25:35 UTC
Could be simplified by using g_string_new ("/usr/lib/debug/.build-id/") instead of g_build_filename, but otherwise looks fine. Feel free to put that patch into our rpm.
Comment 2 Matthias Clasen 2009-04-05 04:46:18 UTC
Ok, seems you didn't want to build it yourself...I've done that for you now.
Comment 3 Will Woods 2009-04-05 17:09:52 UTC
Sorry - got really busy with Beta stuff for a while there. Thanks for applying the patch! AFAICT build-id support is available in the upstream tools (gdb, ld, etc.) so it makes sense to send this patch upstream as well. I'll link to the GNOME bug report once it's available.