Bug 490940
Summary: | Review Request: mod_pubcookie - A solution for single sign-on authentication to websites | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gabriel Somlo <somlo> | ||||
Component: | Package Review | Assignee: | Rafael Aquini <aquini> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | aquini, fedora-package-review, notting | ||||
Target Milestone: | --- | Flags: | aquini:
fedora-review+
kevin: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | mod_pubcookie-3.3.4a-3.el5 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2010-10-06 01:30:18 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Gabriel Somlo
2009-03-18 16:11:07 UTC
Gabriel, Are you still interested in get Pubcookie reviewed? If so, please consider update it to upstream 3.3.4 latest release. Regards Rafael, I updated to 3.3.4a: Spec URL: http://www.contrib.andrew.cmu.edu/~somlo/pubcookie.spec SRPM: http://www.contrib.andrew.cmu.edu/~somlo/pubcookie-3.3.4a-1.fc12.src.rpm Are you interested in reviewing this package ? Thanks, --Gabriel Gabriel, Yes, I'm taking it for review. Upstream has just released a new stable version. Please, consider update this package to it, before we start working. http://pubcookie.org/news/20100820-3.3.5.html Best regards The only 3.3.5 available as of right now is the Windows-specific "3.3.5.msi" (see http://pubcookie.org/downloads.html). I don't think there's a "pubcookie-3.3.5.tar.gz" available. Thanks, --Gabriel Gabriel, My bad... Sorry, I've just followed the announce, without checking the download page. I'll be posting a formal review soon. Best regards! Gabriel, Please consider the following review observations: Good: * License in sources and spec is APL 2.0 which is open source * License text included in the tarball and listed on %file. * Spec is legible and American English * http://www.pubcookie.org/downloads/pubcookie-3.3.4a.tar.gz * Source matches upstream * No locale files * No shared libraries misplaced * No bundled libraries * Not relocatable * No directories created unowned * No duplicate files * Default permissions are set * Package is code * No large documentation * No %doc files are used at runtime * No header files * Not a GUI application * Does not own files or directories from other packages * All filenames are utf8 NEEDSWORK: [1] rpmlint complaints: [rpmbuilder@localhost ~]$ rpmlint /var/lib/mock/fedora-12-i386/result/pubcookie-3.3.4a-1.fc12.i686.rpm /var/lib/mock/fedora-12-i386/result/pubcookie-server-3.3.4a-1.fc12.i686.rpm /var/lib/mock/fedora-12-i386/result/pubcookie-3.3.4a-1.fc12.src.rpm pubcookie.i686: W: spelling-error Summary(en_US) intra -> intr, intro, infra pubcookie.i686: W: invalid-url URL: http://pubcookie.org <urlopen error timed out> pubcookie.i686: W: no-manual-page-for-binary keyclient pubcookie-server.i686: W: invalid-url URL: http://pubcookie.org <urlopen error timed out> pubcookie-server.i686: E: arch-dependent-file-in-usr-share /usr/share/pubcookie/cgi-bin/index.cgi pubcookie-server.i686: W: no-manual-page-for-binary keyserver pubcookie.src: W: spelling-error Summary(en_US) intra -> intr, intro, infra pubcookie.src: W: invalid-url URL: http://pubcookie.org <urlopen error timed out> pubcookie.src: W: invalid-url Source0: http://pubcookie.org/downloads/pubcookie-3.3.4a.tar.gz <urlopen error timed out> 3 packages and 0 specfiles checked; 1 errors, 8 warnings. [2] As a package which relies on httpd, pubcookie rpms & spec should be named mod_pubcookie to correct follow the naming guidelines. See: http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28httpd.2C_pam.2C_and_SDL.29 [3] Does not Build in mock for rawhide, F13 & F14 -- check the attachments for mock rawhide buildlog. Created attachment 442511 [details]
fedora-rawhide mock buildlog
spec URL: http://www.contrib.andrew.cmu.edu/~somlo/mod_pubcookie.spec srpm URL: http://www.contrib.andrew.cmu.edu/~somlo/mod_pubcookie-3.3.4a-2.fc12.src.rpm I believe this addresses all but one of your concerns: mod_pubcookie-server.i686: E: arch-dependent-file-in-usr-share /usr/share/pubcookie/cgi-bin/index.cgi I did that on purpose, per the packgaging guidelines, specifically: http://fedoraproject.org/wiki/Packaging/Guidelines#Web_Applications If you know of another, more recent document that overrides the above (or know of a better location to put a binary index.cgi file), please let me know and I'll change this. Thanks, --Gabriel Gabriel, That's all right, rpmlint does some blatant complaints sometimes. Your work is fine and you have promptly addressed every observation made in my last comment. This package is APPROVED. New Package SCM Request ======================= Package Name: mod_pubcookie Short Description: A solution for single sign-on authentication to websites Owners: somlo Branches: f12 f13 f14 el5 el6 InitialCC: Could you adjust the name/summary of this bug to match the new package name? (then reset the fedora-cvs flag). Thanks. Git done (by process-git-requests). mod_pubcookie-3.3.4a-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mod_pubcookie-3.3.4a-3.fc14 mod_pubcookie-3.3.4a-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mod_pubcookie-3.3.4a-3.fc13 mod_pubcookie-3.3.4a-3.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/mod_pubcookie-3.3.4a-3.fc12 mod_pubcookie-3.3.4a-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mod_pubcookie-3.3.4a-3.el5 mod_pubcookie-3.3.4a-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. mod_pubcookie-3.3.4a-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. mod_pubcookie-3.3.4a-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. mod_pubcookie-3.3.4a-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |