Bug 491566 (powwow)
| Summary: | Review Request: powwow - A console MUD client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <kalevlember> |
| Component: | Package Review | Assignee: | Thomas Sailer <fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, fedora, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2.15-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-09 04:07:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalev Lember
2009-03-22 23:56:50 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1253436 A few fixes to the package. Spec URL: http://www.smartlink.ee/~kalev/powwow.spec SRPM URL: http://www.smartlink.ee/~kalev/powwow-1.2.13-2.fc11.src.rpm * Wed Mar 25 2009 Kalev Lember <kalev> - 1.2.13-2 - Fix the package to own all the directories it creates. - Move development-related docs to devel subpackage. Removing FE-NEEDSPONSOR, as I am now sponsored by Richard W.M. Jones. Spec URL: http://www.smartlink.ee/~kalev/powwow.spec SRPM URL: http://www.smartlink.ee/~kalev/powwow-1.2.14-1.fc11.src.rpm * Wed Apr 15 2009 Kalev Lember <kalev> - 1.2.14-1 - Update to powwow 1.2.14. Spec URL: http://www.smartlink.ee/~kalev/powwow.spec SRPM URL: http://www.smartlink.ee/~kalev/powwow-1.2.14-2.fc11.src.rpm * Thu Apr 16 2009 Kalev Lember <kalev> - 1.2.14-2 - Remove COPYING from %%doc, because it is needed at runtime. Rpmlint is silent: $ rpmlint powwow.spec powwow-1.2.14-2.fc11.src.rpm powwow-1.2.14-2.fc12.x86_64.rpm powwow-debuginfo-1.2.14-2.fc12.x86_64.rpm powwow-devel-1.2.14-2.fc12.x86_64.rpm 4 packages and 1 specfiles checked; 0 errors, 0 warnings. Fedora review powwow-1.2.14-2.fc11.src.rpm 2008-04-17 Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1304042 + OK ! needs attention + rpmlint output + Package is named according to Fedora Package Naming Guidelines + Specfile name matches the package base name + Package follows the Fedora packaging guidelines + License meets guidelines and is acceptable to Fedora GPLv2+ + License matches the actual package license + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm 5c1d600ca8e577dc620c1c15c01cfdf5 ../SOURCES/powwow-1.2.14.tar.gz 5c1d600ca8e577dc620c1c15c01cfdf5 powwow-1.2.14.tar.gz n/a Package builds in mock n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package + Header files should be in -devel n/a Static libraries should be in -static n/a Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 Now some general comments: - Filenames like "muc", "follow", and "movie_play" seem to be fairly generic and thus prone to conflicts in the future; they do not seem to conflict now - follow is described by the accompanying documentation as mainly a debugging aid - should this really be packaged, in the main package? - what is the use case for the -devel package? It contains only header files, no actual lib Let me first talk to upstream about possible name clashes.
Right now I think "follow" and "catrw" should be killed from this package and I'd rename the remaining questionable executables as follows:
muc -> muc-play
movie_play -> powmovie-play
movie2ascii -> powmovie2ascii
> - what is the use case for the -devel package? It contains only header files,
> no actual lib
powwow-devel contains headers that can be used to develop plugins for powwow.
I talked to upstream powwow maintainer and he agreed to remove follow and catrw from "make install" target and to perform the following renames: muc -> powwow-muc movie_play -> powwow-movieplay movie2ascii -> powwow-movie2ascii Spec URL: http://www.smartlink.ee/~kalev/powwow.spec SRPM URL: http://www.smartlink.ee/~kalev/powwow-1.2.14-3.fc11.src.rpm * Mon Apr 20 2009 Kalev Lember <kalev> - 1.2.14-3 - Rework powwow-devel description. - Rename movie_play and muc, remove catrw and follow to avoid possible name clashes and to reflect upstream changes. APPROVED by sailer Thanks for the review, Thomas. Could you please set the fedora-review flag too? New Package CVS Request ======================= Package Name: powwow Short Description: A console MUD client Owners: kalev Branches: F-9 F-10 F-11 InitialCC: cvs done. powwow-1.2.14-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/powwow-1.2.14-3.fc10 powwow-1.2.14-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/powwow-1.2.14-3.fc9 powwow-1.2.14-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/powwow-1.2.14-3.fc11 powwow-1.2.15-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/powwow-1.2.15-1.fc10 powwow-1.2.15-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/powwow-1.2.15-1.fc11 powwow-1.2.15-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/powwow-1.2.15-1.fc9 powwow-1.2.15-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4103 powwow-1.2.15-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-4157 powwow-1.2.15-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4310 powwow-1.2.15-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. powwow-1.2.15-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. powwow-1.2.15-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: powwow New Branches: el6 Owners: kalev Git done (by process-git-requests). |