Bug 491578
| Summary: | Review Request: RasmusDSP - Embeddable Audio/MIDI processor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.1-2.20090321cvs.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-30 02:27:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 492203 | ||
|
Description
Orcan Ogetbil
2009-03-23 05:21:03 UTC
rpmlint: RasmusDSP-editor.x86_64: W: no-documentation There is not much we can do about this. Fedora review RasmusDSP-0.1-1.20090321cvs.fc10.src.rpm 2009-05-28 $ rpmlint *.rpm RasmusDSP.spec RasmusDSP-editor.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 0 errors, 1 warnings. * OK ? needs attention * rpmlint output is OK * package is named according to the guidelines * spec file is named after the package * package is licensed under a Fedora approved license (BSD) * package license matches license statements in the sources * no license file present in sources * spec file is written in legible English * sources matches upstream * package builds in mock (Fedora 10) ? jack-audio-connection-kit-devel - is it needed as a BuildRequires? "grep -lr jack RasmusDSP" does not return any matches * package owns the directories it creates * no duplicate files * permissions are sane and %files has %defattr * %clean clears buildroot * spec file uses macros consistently * contains code, not content * subpackages requires main with fully qualified version * desktop files are installed using desktop-file-install * %install clears buildroot * installed filenames are UTF-8 * icon cache handling according to (draft) guidelines (In reply to comment #2) > Fedora review RasmusDSP-0.1-1.20090321cvs.fc10.src.rpm 2009-05-28 > > ? jack-audio-connection-kit-devel - is it needed as a BuildRequires? > "grep -lr jack RasmusDSP" does not return any matches > Thanks for the review and the catch. No, jack is not needed for this. It must have slipped through while I was copying/pasting stuff from another SPEC file. Spec URL: http://oget.fedorapeople.org/review/RasmusDSP.spec SRPM URL: http://oget.fedorapeople.org/review/RasmusDSP-0.1-2.20090321cvs.fc10.src.rpm Changelog: 0.1-2.20090321cvs - Remove unneeded BR: jack-audio-connection-kit-devel Package approved. Many thanks! New Package CVS Request ======================= Package Name: RasmusDSP Short Description: Embeddable Audio/MIDI processor Owners: oget Branches: F-9 F-10 F-11 InitialCC: CVS done. RasmusDSP-0.1-2.20090321cvs.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/RasmusDSP-0.1-2.20090321cvs.fc9 RasmusDSP-0.1-2.20090321cvs.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/RasmusDSP-0.1-2.20090321cvs.fc11 RasmusDSP-0.1-2.20090321cvs.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/RasmusDSP-0.1-2.20090321cvs.fc10 RasmusDSP-0.1-2.20090321cvs.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. RasmusDSP-0.1-2.20090321cvs.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. RasmusDSP-0.1-2.20090321cvs.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |