Bug 491618 (mingw32-libsqlite3x)

Build fails:

 i686-pc-mingw32-g++ -DHAVE_CONFIG_H -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOUR\
CE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields -O2 -Wall -c sqlite3\
x_command.cpp  -DPIC
env: i686-pc-mingw32-g++: Permission denied
make[1]: *** [sqlite3x_command.lo] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/libsqlite3x-2007.10.18'
make: *** [all] Error 2

Probable cause: missing BuildRequires: mingw32-gcc-c++

Update:
Spec URL: http://sailer.fedorapeople.org/mingw32-libsqlite3x.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-libsqlite3x-20071018-6.fc11.src.rpm

Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1322147

Fedora review mingw32-libsqlite3x-20071018-6.fc11.src.rpm 2009-04-28

* OK
! needs attention

* rpmlint output
  Only expected Errors/Warnings from a mingw package

* Package is named according to Fedora mingw packaging guidelines

* Spec file is named as the package

* Package follows the Fedora mingw packaging guidelines

* License is MIT, which is Fedora approved

* The license is the same as the corresponding native package

! How was it determined that the native's package license should be MIT?

* There is no License file in the source tarfile (though some license
  statements are in the README file which is packaged).

* The spec file is written in legible English

* Source matches upstream

f5015c83030236205aec1494b13ee334  libsqlite3x-2007.10.18.tar.gz
f5015c83030236205aec1494b13ee334  SRPM/libsqlite3x-2007.10.18.tar.gz

* According to guidelines the version should match the version of the
  corresponding Fedora package - which it does.

* Package builds in mock (Fedora 10)

! The package contains documentation already present in the native
  Fedora package

* BuildRequires look sane

! But is there a reason for having the "BuildArch: noarch" listed in
  the middle of the list of Thr BuildRequies?

* Owns the directories it creates

* No duplicate files

* %files has %defattr

* %clean clears %buildroot

* Specfile uses macros consistently

* Package does not own other's directories

* %install clears %buildroot

* Installed filenames are valid UTF8

(In reply to comment #3)

Updated:
SRPM: http://sailer.fedorapeople.org/mingw32-libsqlite3x-20071018-7.fc11.src.rpm
Spec: http://sailer.fedorapeople.org/mingw32-libsqlite3x.spec

> ! How was it determined that the native's package license should be MIT?

Good you noticed that. It isn't MIT, it is under zlib. There are a few copyright notices as comments in source files, eg. sqlite3x.hpp.
I changed the license tag in the above spec file, and I will also change the native package. David Woodhouse (the reviewer of the native package), has also been notified, he is ok with the change.

> ! The package contains documentation already present in the native
>   Fedora package

Removed.

> ! But is there a reason for having the "BuildArch: noarch" listed in
>   the middle of the list of Thr BuildRequies?

Reordered.

Do you still need BuildRequires: doxygen?

Anyway, that you can check post-review.

Package approved.

Thank you for the review.


New Package CVS Request
=======================
Package Name: mingw32-libsqlite3x
Short Description:  MinGW Windows C++ wrapper for the sqlite database
Owners: sailer rjones
Branches: F-10 F-11
InitialCC:

cvs done.

mingw32-libsqlite3x-20071018-7.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/mingw32-libsqlite3x-20071018-7.fc11

mingw32-libsqlite3x-20071018-7.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-libsqlite3x-20071018-7.fc10

mingw32-libsqlite3x-20071018-7.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

mingw32-libsqlite3x-20071018-7.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.