Bug 491636
| Summary: | CAPS plugins incorrectly produce silence (-ffast-math, -ffinite-math-only) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Thompson <fedora> | ||||
| Component: | ladspa-caps-plugins | Assignee: | Hans de Goede <hdegoede> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | hdegoede, nando | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.4.2-4.fc9 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-03-24 10:18:25 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
(In reply to comment #0) > At present I have no idea if this is a Sorry, pressed commit by accident. This sentence was going to observe that I've no idea if this is a problem in the compiler or a problem in the code exposed by using a 'better' compiler. Instinct and experience suggest probably the later ;-) (In reply to comment #0) > Actual results: > > Peak output: 0 > (should take less than 2 seconds on modern h/ware) > > > Expected results: > > Peak output: 20861.3 [value will vary based on test signal, expect non-zero] > (takes >45 seconds) Rats. Not having a good day. I've reversed these comments. If *does* take >45 seconds, it *should* take no more than 2. Thanks for reporting this, can you please try the version here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1254588 I simply completely removed -ffast-math from the flags used for compilation completely as it is not part of the standard build flags for Fedora, I only put it in there in the first place as upstream uses it as its default, and usally -ffast-math is safe to use when upstream does so. (In reply to comment #3) > Thanks for reporting this, can you please try the version here: > http://koji.fedoraproject.org/koji/taskinfo?taskID=1254588 Tested on x86_64 and things look much better. Will try i386 tomorrow. > I simply completely removed -ffast-math from the flags used for compilation > completely as it is not part of the standard build flags for Fedora, I only > put it in there in the first place as upstream uses it as its default, and > usally > -ffast-math is safe to use when upstream does so. Fair enough. I'll try to get in touch with the author regarding the problem though. For tools like CAPS performance does matter (though correctness more so) so it would nice to be able to get the flag back on if we understand what is going on (most CAPS plugins deliberately inject non-audible noise to keep the f.p. maths from taking slow paths: the author cares about this stuff). Looks fine on i386 as well. Thanks for testing! I've just done an official build with the same fix, this will show up in rawhide when it unfreezes from the beta freeze (so when the beta is released). Thanks for testing! I've just done an official build with the same fix, this will show up in rawhide when it unfreezes from the beta freeze (so when the beta is released). For the benefit of anyone using bugzilla search... It looks like this problem first appeared in Fedora 9 and therefore affects affects both F9 and F10. (In reply to comment #8) > For the benefit of anyone using bugzilla search... > > It looks like this problem first appeared in Fedora 9 and therefore affects > affects both F9 and F10. Ok, that is good to know, so ladspa-caps-plugin is busted in F-9 and F-10 too? If so I'll do an update there to fix this. (In reply to comment #9) > > It looks like this problem first appeared in Fedora 9 and therefore affects > > affects both F9 and F10. > > Ok, that is good to know, so ladspa-caps-plugin is busted in F-9 and F-10 too? > If so I'll do an update there to fix this. Indeed. Had I been having a good day with bugzilla I'd have marked the fact I was running F10 in the Version: field. So it is certainly broken in F10 and the package has the same name in F9 and F10. Strictly speaking I don't know if packages called ladspa-caps-plugins-0.4.2-2.fc9.i386 are built with same compiler in F9 and F10 (does the same name mean they are not rebuilt at all or only that the .spec file hasn't been changed?). (In reply to comment #10) > Strictly speaking I don't know if packages called > ladspa-caps-plugins-0.4.2-2.fc9.i386 are built with same compiler in F9 and F10 > (does the same name mean they are not rebuilt at all or only that the .spec > file hasn't been changed?). It means they have not been rebuild at all, the .fc# extension is created automatically at build time. So the contents of the F-9 and F-10 rpms are identical. Note the rpms themself may not have to same md5sum due to being re-signed with another key (rpms have their signature embedded). So if you're seeing this on F-10, it will be there on F-9 as well. I will prepare updates for both F-9 and F-10. ladspa-caps-plugins-0.4.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/ladspa-caps-plugins-0.4.2-4.fc10 ladspa-caps-plugins-0.4.2-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/ladspa-caps-plugins-0.4.2-4.fc9 ladspa-caps-plugins-0.4.2-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. ladspa-caps-plugins-0.4.2-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 336285 [details] Tweak build system to disable problematic optimization. Description of problem: Many of the CAPS plugins incorrectly produce silence rather than anything derived from the input. Also plugins run *really* slowly. Version-Release number of selected component: ladspa-caps-plugins-0.4.2-2.fc9.i386 How reproducible: Apply (for example) the AmpVTS plugin. Steps to Reproduce: 1. Generate a test file (I used audacity to generate 30 second sine wave in .wav file). 2. applyplugin sine.wav sine-ampvts.wav /usr/lib/ladspa/caps.so AmpVTS \ 0 2.25 0.5 1 0.75 0.250075 0.750025 Actual results: Peak output: 0 (should take less than 2 seconds on modern h/ware) Expected results: Peak output: 20861.3 [value will vary based on test signal, expect non-zero] (takes >45 seconds) Additional info: Caused by the application of gcc's -ffinite-math-only option (via -ffast-math). At present I have no idea if this is a Also affects x86_64 systems (presumably for the same reason).