Bug 491650
| Summary: | Review Request: libica - Library for accessing ICA hardware crypto on IBM zSeries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Horák <dan> |
| Component: | Package Review | Assignee: | Darryl L. Pierce <dpierce> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dpierce, fedora-package-review, notting, tross |
| Target Milestone: | --- | Flags: | dpierce:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-06 07:51:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dan Horák
2009-03-23 14:00:08 UTC
Is the warning regarding no documentation considered fatal? Other than that, this package looks fine to me. I'll approve this and the documentation issue should be fixed or ignored.
MUST: rpmlint must be run on every package. The output should be posted in the review.[1]
rpmlint output:
(mcpierce@mcpierce-laptop:Desktop)$ for rpm in *.rpm; do rpmlint $rpm; done
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
libica-devel.s390x: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
libica-utils.s390x: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7]
MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] [OK]
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] [OK]
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [22] [OK]
SHOULD: The reviewer should test that the package builds in mock. [29] [OK]
SHOULD: The package should compile and build into binary rpms on all supported architectures. [30] [OK]
(In reply to comment #1) > Is the warning regarding no documentation considered fatal? Other than that, > this package looks fine to me. I'll approve this and the documentation issue > should be fixed or ignored. The warning is harmless here, because there is no documentation other than the AUTHORS and LICENSE files and these are included in the main package that will be always installed (it is the library). New scratch build using the same srpm this time for F-11 is at https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=55252 New Package CVS Request ======================= Package Name: libica Short Description: Library for accessing ICA hardware crypto on IBM zSeries Owners: sharkcz Branches: F-11 CVS Done Imported and built. |