Bug 491744

Summary: devicekit-disk should not be using /tmp, it should use /var/run
Product: [Fedora] Fedora Reporter: Daniel Walsh <dwalsh>
Component: DeviceKit-disksAssignee: David Zeuthen <davidz>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: davidz, mclasen
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-07 04:45:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Daniel Walsh 2009-03-23 20:00:00 UTC
Description of problem:

Why is this using /tmp rather then /var/run/devkit for its temporary files?

Users can much around in /tmp they can not in /var/run  So tempfiles should be created in /var/run

allow devicekit_disk_t tmp_t:dir { search read create mounton write getattr rmdir remove_name add_name };
allow devicekit_disk_t tmp_t:file { read write create unlink open };


Created a partition with palimsest to create these avc messages.

Comment 1 Matthias Clasen 2009-04-07 04:45:53 UTC
Should be fixed in DeviceKit-disks-004

Comment 2 David Zeuthen 2009-04-07 16:56:27 UTC
While I did fix this "bug" please note that devkit-disks-daemon will spawn a number of tools (depending of file system type) etc. that in turn may use /tmp.

What I'm trying to say is that it is extremely optimistic to think that denying access to /tmp is going to work. While it may work for simple tests it's just going to break some corner case either now or in the future.

Comment 3 Daniel Walsh 2009-04-07 18:16:35 UTC
That is fine, and I will give devicekit the ability to create files in /tmp, but we should not do this by default.