Bug 491820

Summary:	Review Request: ibus-sayura - The Sinhala IME engine for IBus
Product:	[Fedora] Fedora	Reporter:	Pravin Satpute <psatpute>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, petersen
Target Milestone:	---	Flags:	panemade: fedora-review+ petersen: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-26 11:12:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pravin Satpute 2009-03-24 09:54:12 UTC

SPEC URL: http://pravins.fedorapeople.org/ibus-sayura/ibus-sayura.spec
SRPM URL: http://pravins.fedorapeople.org/ibus-sayura/ibus-sayura-1.0.0.20090324-1.fc11.src.rpm

Description: The Sinhala IME Engine for IBus

Comment 1 Parag AN(पराग) 2009-03-25 06:06:52 UTC

Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1257587
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
e426c362f97ddc0647dc732f684e86d9  ibus-sayura-1.0.0.20090324.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.

Suggestions:
1) remove following line from SPEC
rm -f $RPM_BUILD_ROOT%{python_sitearch}/_sayura.la

2) change following line to keep timestamps 
make DESTDIR=${RPM_BUILD_ROOT} install
to
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

APPROVED.

Comment 2 Pravin Satpute 2009-03-25 07:19:14 UTC

Thanks Parag for review

I will update as per suggestions at the time of cvs commit

Comment 3 Pravin Satpute 2009-03-25 08:06:41 UTC

New Package CVS Request
=======================
Package Name: ibus-sayura
Short Description: The Sinhala IME engine for IBus platform
Owners: pravins
Branches: devel
InitialCC:
Cvsextras Commits: yes

Comment 4 Jens Petersen 2009-03-26 09:21:49 UTC

cvs admin

Comment 5 Pravin Satpute 2009-03-26 11:12:01 UTC

built it for rawhide

thanks jens