Bug 492122 (mingw32-cairomm)
| Summary: | Review Request: mingw32-cairomm - MinGW Windows C++ API for the cairo graphics library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Sailer <fedora> |
| Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-mingw, fedora-package-review, kalevlember, notting, rjones |
| Target Milestone: | --- | Flags: | rjones:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.6.2-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-09 16:09:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 492110 | ||
| Bug Blocks: | 492125 | ||
|
Description
Thomas Sailer
2009-03-25 13:40:49 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1281702 Rpmlint is quiet: $ rpmlint mingw32-cairomm-1.8.0-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-cairomm-1.8.0-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + OK ! needs attention + rpmlint output + Package is named according to Fedora MinGW packaging guidelines + Specfile name matches the package base name + Package follows the Fedora MinGW packaging guidelines + License meets guidelines and is acceptable to Fedora LGPLv2+ + License matches the actual package license It is also the same as in the corresponding Fedora cairomm package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm 15c0f56eee57bb418c38463a6297d715 cairomm-1.8.0.tar.gz 15c0f56eee57bb418c38463a6297d715 SRPM/cairomm-1.8.0.tar.gz + Package builds in mock (Fedora Rawhide i586) n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static + Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 Note: I am not in packager group, so I cannot set fedora‑review+ flag. setting fedora-review+ on the basis of kalev's review New Package CVS Request ======================= Package Name: mingw32-cairomm Short Description: MinGW Windows C++ API for the cairo graphics library Owners: sailer rjones Branches: F-10 InitialCC: Thank you, Kalev and Richard, for the quick review! cvs done. mingw32-cairomm-1.6.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-cairomm-1.6.2-2.fc10 mingw32-cairomm-1.6.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |