Bug 492125 (mingw32-pangomm)
| Summary: | Review Request: mingw32-pangomm - MinGW Windows C++ interface for Pango | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Sailer <fedora> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-mingw, fedora-package-review, kevin, notting |
| Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.14.1-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-13 19:41:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 492122 | ||
| Bug Blocks: | 492130 | ||
|
Description
Thomas Sailer
2009-03-25 13:53:40 UTC
Fedora review mingw32-pangomm-2.14.1-1.fc11.src.rpm 2008-04-07 * OK ! needs attention * rpmlint output Only expected Errors/Warnings from a mingw package * Package is named according to Fedora mingw packaging guidelines * Spec file is named as the package * Package follows the Fedora mingw packaging guidelines * The stated license (LGPLv2+) is a Fedora approved license * The stated license is the same as the one for the corresponding Fedora package * The package contains the license file (COPYING) * The spec file is written in legible English * Sources matches upstream c67228ea93dd977394d2872b61754b53 pangomm-2.14.1.tar.bz2 c67228ea93dd977394d2872b61754b53 SRPM/pangomm-2.14.1.tar.bz2 ! Accoding to guidelines the version should match the version of the corresponding Fedora package. The version in Fedora 11 is now 2.24.0 (built yesterday 2009-04-06 - so no shadow falls on the requester.) http://koji.fedoraproject.org/koji/buildinfo?buildID=96784 Fedora 10 so far remains at 2.14.1 (in case a Fedora 10 package is considered) * Package builds in mock (Fedora 10) * BuildRequires look sane * Owns the directories it creates * No duplicate files * %files has %defattr * %clean clears %buildroot * Specfile uses macros consistently * Package does not own other's directories * %install clears %buildroot * Installed filenames are valid UTF8 Thank you for taking the review! I have updated the package: http://sailer.fedorapeople.org/mingw32-pangomm.spec http://sailer.fedorapeople.org/mingw32-pangomm-2.24.0-1.fc11.src.rpm The updated package builds in mock (Fedora 10) and its sources match upstream: fa0f44c37499433455857becad4bbcda pangomm-2.24.0.tar.bz2 fa0f44c37499433455857becad4bbcda SRPM/pangomm-2.24.0.tar.bz2 The rest of the review in comment 1 still applies. There is a tiny error in the specfile. The Source0 should be .../2.24/... not .../2.14/... due to an oversight when the package was updated: Source0: http://ftp.gnome.org/pub/GNOME/sources/pangomm/2.24/pangomm-%{version}.tar.bz2 But that can be fixed without having to send an updated version for me to approve. Package approved. New Package CVS Request ======================= Package Name: mingw32-pangomm Short Description: MinGW Windows C++ interface for Pango Owners: sailer rjones Branches: F-10 InitialCC: cvs done. mingw32-pangomm-2.14.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-pangomm-2.14.1-1.fc10 mingw32-pangomm-2.14.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |