Bug 492181
Summary: | Review Request: gpxe - A network boot loader | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matt Domsch <matt_domsch> | ||||
Component: | Package Review | Assignee: | srinivas <srinivas_ramanatha> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review, gcosta, itamar, k.georgiou, mtasaka, notting, rolf, srinivas_ramanatha, tjb, vanmeeuwen+fedora, virt-maint | ||||
Target Milestone: | --- | Flags: | srinivas_ramanatha:
fedora-review+
kevin: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 0.9.7-4.fc11 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-06-02 14:25:50 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 457979 | ||||||
Attachments: |
|
Description
Matt Domsch
2009-03-25 18:51:48 UTC
I have a question, this package will obsolete etherboot ? http://koji.fedoraproject.org/koji/packageinfo?packageID=6998 Yes, sir. Provided everything moves according to the plan. 1: Now that we don't have a kvm package anymore, the subpackage should be really called roms-qemu, not roms-kvm 2: Why git? Doesn't gpxe have a fresh enough release? 3: ExclusiveArch: %{ix86} x86_64 => this is wrong. It means ppc and others will never get the noarch subpackages. Take a look on how extboot does it. 1) good catch, will change 2) upstream doesn't release tarballs. I'm OK using the v0.9.7 tag if we don't need any diffs since then. 3) will investigate Updated files with changes suggested in comment #3. http://domsch.com/linux/fedora/gpxe/gpxe.spec http://domsch.com/linux/fedora/gpxe/gpxe-0.9.7-1.src.rpm And a few more updates: * add subpackage gpxe-bootimgs containing ISO, USB, and floppy images * add BRs needed for generating the above images * add USAGE doc for above images * change Source0 to point at released tarballs, not git Built in mock, logs and results at http://domsch.com/linux/fedora/gpxe/. why you don't include dist-tag ? Can you include a koji scratch build in dist-f11 ? -make %{?_smp_mflags} +make %{?_smp_mflags} ISOLINUX_BIN=/usr/share/syslinux/isolinux.bin Itamar: re no dist tag: the executables being produced run in BIOS context, not OS distribution context. There's no reason we couldn't use the same noarch (x86) executables across multiple OS versions. Koji scratch-build started: http://koji.fedoraproject.org/koji/taskinfo?taskID=1259845 Created attachment 336850 [details]
patch to build in koji
look
Gotcha. Applied those changes, thanks! http://koji.fedoraproject.org/koji/taskinfo?taskID=1259897 built successfully. Where's the latest package with those changes applied? I only see the 0.9.7-1 spec from comment #5. (In reply to comment #12) > Where's the latest package with those changes applied? I only see the 0.9.7-1 > spec from comment #5. I belive in koji, until the next cleanup. I'm uploading the spec and srpm which match the last koji scratch build, into http://domsch.com/linux/fedora/gpxe/ Review: Fix all rpmlint warnings: [root@localhost ~]# rpmlint gpxe-* gpxe.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 10) gpxe-bootimgs.noarch: W: summary-not-capitalized gPXE - bootable USB, CD, floppy images and GRUB format gpxe-roms.noarch: W: summary-not-capitalized gPXE - boot roms in .rom format gpxe-roms-qemu.noarch: W: summary-not-capitalized gPXE - boot roms supported by QEMU, .rom format naming: ok spec file name matches: ok license = GPLv2 and BSD: ok license tag: ok spec in english: ok spec legible: ok no prebuild binaries: ok no packager, vendor, copyright, tags: ok summary and description tags: ok no rpaths: ok no config files: ok no initscripts: ok no desktop files: ok consistent use of macros: ok no makeinstall: ok no lang files: ok scriptlets: ok no conditional deps: ok builds with a normal user account: ok not relocatable: ok code, not content: ok directory ownership: ok users and groups: ok not a web app: ok conflicts: ok no kmods: ok no files under /srv: ok source matches: ok calls ldconfig appropriately: ok no duplicate files: ok file permissions: ok libtool archives removed: ok %clean section: ok no large docs, no need for -doc subpackage: ok %doc usage ok no static libs: ok no pkgconfig files: ok all libtool .la files removed: ok dir ownership correct: ok %install does rm: ok filenames UTF8: ok look at comment #1 and comment #2 may be missing obsolete etherboot ? I don't know that it obsoletes etherboot in the RPM sense. The two can co-exist, and presumably one could load an etherboot orom into one instance of QEMU, while loading a gPXE orom into another instance. Also, the other etherboot images and gPXE images, meant for use on cards etc, can absolutely co-exist. OK, I fixed the two rpmlint warnings. $ rpmlint gpxe.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Please approve. (In reply to comment #18) you should run rpmlint against rpm files, example [itamar@itamar gpxe]$ ls *.rpm gpxe-0.9.7-1.src.rpm gpxe-bootimgs-0.9.7-1.noarch.rpm gpxe-roms-0.9.7-1.noarch.rpm gpxe-roms-qemu-0.9.7-1.noarch.rpm [itamar@itamar gpxe]$ rpmlint *.rpm gpxe.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) gpxe-bootimgs.noarch: W: summary-not-capitalized gPXE - bootable USB, CD, floppy images and GRUB format gpxe-roms.noarch: W: summary-not-capitalized gPXE - boot roms in .rom format gpxe-roms-qemu.noarch: W: summary-not-capitalized gPXE - boot roms supported by QEMU, .rom format 4 packages and 0 specfiles checked; 0 errors, 4 warnings. the warning about summary-not-capitalized can be ignored so please fix the warning about mixed-use-of-spaces-and-tabs for the there are something wrong with this package. since there are no rpms for PPC and PPC64, why not use ExclusiveArch: %ix86 x86_64 ? Honestly folks, we're getting a bit pedantic with the tabs vs spaces warning. I didn't rebuild the RPMs after fixing that just to run rpmlint to prove that I can run 'tr' to remove tabs. Running rpmlint against the spec file is sufficient to see that I fixed those. Regarding exclusivearch - these ROMs run either on a physical machine where exclusivearch would make sense, or can be run inside QEMU on a completely different arch, where the RPM architecture makes no sense whatsoever (hence they're noarch). Of course here are ppc and ppc64 packages. They are just not built there. Setting fedora-review flag to "+". New Package CVS Request ======================= Package Name: gpxe Short Description: A network boot loader Owners: mdomsch glommer Branches: F-11 F-10 F-9 EL-5 InitialCC: cvs done. gpxe-0.9.7-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/gpxe-0.9.7-2.fc11 gpxe-0.9.7-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/gpxe-0.9.7-3.fc10 gpxe-0.9.7-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/gpxe-0.9.7-2.fc9 gpxe-0.9.7-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gpxe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4900 gpxe-0.9.7-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update gpxe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-4901 gpxe-0.9.7-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gpxe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4920 I needed undionly.kpxe to make a server do an iSCSI boot, as described in http://www.etherboot.org/wiki/pxechaining. AFAIK this file isn't part if the compiled packages, I took it from the rpmbuild after building the binary packages from sources. I'd suggest to include the undionly.kpxe in one of the binary packages if it actually isn't in one of them. Thanks for catching that Rolf. Building in koji now, with undionly.kpxe now included in the -bootimgs subpackage. http://koji.fedoraproject.org/koji/taskinfo?taskID=1364843 gpxe-0.9.7-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/gpxe-0.9.7-4.fc11 gpxe-0.9.7-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/gpxe-0.9.7-4.fc10 gpxe-0.9.7-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/gpxe-0.9.7-4.fc9 gpxe-0.9.7-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gpxe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5228 gpxe-0.9.7-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gpxe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5243 gpxe-0.9.7-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update gpxe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-5260 gpxe-0.9.7-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. gpxe-0.9.7-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. gpxe-0.9.7-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 553055 has been marked as a duplicate of this bug. *** |