Bug 492252
| Summary: | Review Request: libdwarf - Library to access the DWARF Debugging file format | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Suravee Suthikulpanit <suravee.suthikulpanit> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, orion, panemade, tom | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.20090324-4.fc10 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-04-01 17:09:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Suravee Suthikulpanit
2009-03-26 05:15:35 UTC
NOTE: - The libdwarf package has 3 sub-packages (libdwarf-devel, libdwarf-tools, libdwarf-doc). - "rpmlint -iv" outputs are quiets on all RPMs. Created attachment 336756 [details]
Fix some issues
This is modified SPEC based on preliminary review. Can you also drop either one utility dwarfdump or dwarfdump2? I see both are same in functionality.
Modified SPEC fixes
- package version number
- removed -doc subpackage
- drop libdward.a file as we generally don't ship static files.
- Fix Requires
SPEC: http://suravee.fedorapeople.org/libdwarf-0.20090324-2/libdwarf.spec SRPM: http://suravee.fedorapeople.org/libdwarf-0.20090324-2/libdwarf-0.20090324-2.fc10.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1266188 NOTE: - "rpmlint -iv" is quiet on all packages. Concerns: - "AutoreqProv: no" in libdwarf-tools package helps the installation issue below. [root@localhost rpmbuild]# rpm -Uvh /root/rpmbuild/RPMS/x86_64/libdwarf-0.20090324-2.fc10.x86_64.rpm Preparing... ########################################### [100%] 1:libdwarf ########################################### [100%] [root@localhost rpmbuild]# rpm -Uvh /root/rpmbuild/RPMS/x86_64/libdwarf-tools-0.20090324-2.fc10.x86_64.rpm error: Failed dependencies: libdwarf.so()(64bit) is needed by libdwarf-tools-0.20090324-2.fc10.x86_64 Look at usage of AutoreqProv at http://docs.fedoraproject.org/drafts/rpm-guide-en/ch03s02.html#id2932808 To install dependencies, you need to list all rpms and then install. like in this case you should rpm -Uvh /root/rpmbuild/RPMS/x86_64/libdwarf-0.20090324-2.fc10.x86_64.rpm /root/rpmbuild/RPMS/x86_64/libdwarf-tools-0.20090324-2.fc10.x86_64.rpm Spec URL: http://ftp-developer.amd.com/user/ssuthiku/libdwarf-0.20090324-3/libdwarf.spec SRPM URL: http://ftp-developer.amd.com/user/ssuthiku/libdwarf-0.20090324-3/libdwarf-0.20090324-3.fc9.src.rpm NOTE: - "rpmlint -iv" is quiet on all packages. SPEC: http://suravee.fedorapeople.org/libdwarf-0.20090324-4/libdwarf.spec SRPM: http://suravee.fedorapeople.org/libdwarf-0.20090324-4/libdwarf-0.20090324-4.fc10.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1269499 NOTE: - "rpmlint -iv" is quiet on all packages. Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1269499 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4e603955797a1d5d314a9489a4342c24 libdwarf-20090324.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libdwarf-0.20090324-4.fc11.i586 => Provides: libdwarf.so.0.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdwarf.so.0.0 rtld(GNU_HASH) + Package libdwarf-devel-0.20090324-4.fc11.i586 => Requires: libdwarf.so.0.0 APPROVED. Thank you for your approval. New Package CVS Request ======================= Package Name: libdwarf Short Descriptions: Library to access the DWARF Debugging file format Owners: suravee Branches: F-10 InitialCC: paragn CVS Done libdwarf-0.20090324-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libdwarf-0.20090324-4.fc10 libdwarf-0.20090324-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: libdwarf New Branches: F-11 Owners: suravee There is already a populated F-11 branch. Don't forget to use "cvs update -d". I would like to see this in EPEL6. It appears to build fine there. Tom/Parag - do you want to maintain it there or shall I? You can maintain this in EPEL6. I'm happy for you to do it Orion. Will do. Thanks for the response. Package Change Request ====================== Package Name: libdwarf New Branches: el6 Owners: orion InitialCC: Git done (by process-git-requests). |