Bug 492383
| Summary: | Review Request: netstat-nat - A tool that displays NAT connections | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | nucleo <alekcejk> |
| Component: | Package Review | Assignee: | Susi Lehtola <susi.lehtola> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, susi.lehtola |
| Target Milestone: | --- | Flags: | susi.lehtola:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.4.9-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-31 20:28:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
nucleo
2009-03-26 17:07:48 UTC
rpmlint output:
netstat-nat-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/netstat-nat-1.4.9/netstat-nat.c
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
- You need to remove the executable perms in %setup.
- Time stamps are not preserved. Use
make DESTDIR=%{buildroot} INSTALL="install -p" install
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: Items in %doc do not affect runtime of application. OK
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
(In reply to comment #1) > - You need to remove the executable perms in %setup. > > - Time stamps are not preserved. Use > make DESTDIR=%{buildroot} INSTALL="install -p" install - Fixed file permissions and time stamps Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/netstat-nat/netstat-nat.spec SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/netstat-nat/netstat-nat-1.4.9-2.fc10.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1260694 Okay, looks good. The package adheres to the guidelines and is thus APPROVED. (In reply to comment #3) Thank you for review. New Package CVS Request ======================= Package Name: netstat-nat Short Description: A tool that displays NAT connections Owners: nucleo Branches: F-9 F-10 InitialCC: Aren't you going to branch for EPEL (EL-4, EL-5)? This would be very useful there too, and due to its simplicity very easy to maintain. (In reply to comment #5) > Aren't you going to branch for EPEL (EL-4, EL-5)? This would be very useful > there too, and due to its simplicity very easy to maintain. Can you give me more information? I already setup plague-client as this described in FAQ http://fedoraproject.org/wiki/PackageMaintainers/UsingPlagueClientFaq What next should I do to add netstat-nat to EPEL? You need to make CVS requests also for the EL-4 and EL-5 branches to get them :) (In reply to comment #7) OK But as I understood there are different build systems. For EPEL I should do the same as for Fedora(cvs-import.sh, make build, make update)? New Package CVS Request ======================= Package Name: netstat-nat Short Description: A tool that displays NAT connections Owners: nucleo Branches: F-9 F-10 EL-4 EL-5 InitialCC: Yeah, except that you don't do make update; the built package goes to the EPEL testing repository and is then pushed later on to the stable repository. This will change shortly, though, when EPEL will switch to koji instead of Plague. (In reply to comment #9) OK. Thank you. cvs done. netstat-nat-1.4.9-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/netstat-nat-1.4.9-2.fc9 netstat-nat-1.4.9-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/netstat-nat-1.4.9-2.fc10 Package Change Request ====================== Package Name: netstat-nat New Branches: F-11 Owners: nucleo netstat-nat-1.4.9-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. netstat-nat-1.4.9-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |