Bug 492396

Uhm... this project seems dead (no releases since 2004, forum infested by spam, etc).
Are you sure you want to maintain it in Fedora? Looks like you will become upstream for it, and there are several alternatives out there

I don't particularly care about this project, but it was bundled with websvn which I submitted too, so I packaged it. My understanding of the guidelines is we don't want any private copy of anything bundled into another package.

yes, you are right, despite in my experience php projects do not only embed other projects code, but often they also patches them :(

If you haven't before, please double check if the dependent project has the very same code you're submitting here.

Fortunately, in this case, the embedded code is not patched.
I also checked for php-geshi. I've packaged GeSHI 1.0.8.2, while websvn embed 1.0.8.1. The embedded 1.0.8.1 code is not patched either, so I'm just bumping doing a minor version bump.

ok great. Let's see if we can move this forward. 

As noted on bug 492395, it seems that you can just require php-common because it requires php.

Then, I am not sure if there are guidelines against it, but installing the file in {datadir}/php is probably not a wise idea. What about putting it in a subdirectory (for example feedcreator would do). In that case, please remember to let the package own the directory.

(In reply to comment #5)
> ok great. Let's see if we can move this forward. 
> 
> As noted on bug 492395, it seems that you can just require php-common because
> it requires php.
> 
Or the other way round, just require php. That's what I've done on my local copy.

> Then, I am not sure if there are guidelines against it, but installing the file
> in {datadir}/php is probably not a wise idea. What about putting it in a
> subdirectory (for example feedcreator would do). In that case, please remember
> to let the package own the directory.

Not sure what's best here. As this is only one file, I think it's ok to let it at the root of the php include dir. And anyway, looking at the pear include dir, I see that's what is done : /usr/share/pear/someclass.php, then a /usr/share/pear/someclass subdir with everything else. That's what I've done for php-geshi (https://bugzilla.redhat.com/show_bug.cgi?id=492395).

(In reply to comment #6)
> > Then, I am not sure if there are guidelines against it, but installing the file
> > in {datadir}/php is probably not a wise idea.

According to the guidelines, this is correct :
http://fedoraproject.org/wiki/Packaging/PHP#File_Placement

Ouch, and I did read that page, missing that sentence :(

in the case I think I can review this package

Review:

* Package name is correct
* spec file name correct
* spec file is legible and in english
* License field is correct and acceptable in Fedora
* License text is included in package

* sources match upstream
* macros used consistently

* Builds correctly on F-10
* rpmlint is silent

APPROVED

Thanks for the review Gianluca.

New Package CVS Request
=======================
Package Name: php-feedcreator
Short Description: Create RSS feeds
Owners: xavierb
Branches: F-9 F-10 F-11 EL-5
InitialCC:

cvs done.

php-feedcreator-1.7.2-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/php-feedcreator-1.7.2-3.fc9

php-feedcreator-1.7.2-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/php-feedcreator-1.7.2-3.fc10

php-feedcreator-1.7.2-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/php-feedcreator-1.7.2-3.fc11

One last remark. It would be nice to check (I guess repoquery would work for this) if other php projects we are packaging embeds the feedcreator class and file bugs against them.

Good point. It seems phpTodo is bundling this lib, but the phpTodo author added a feature to it and bumped the version to 1.7.3,
I've also found another project on sourceforge (http://feedcreator.sourceforge.net) which ships a patched 1.7.2 version. I'll try to contact both the phpTodo author and the owner of the sourceforge project to see what can be done about this.
Meanwhile, I've filed bug #496463 against phpTodo.

php-feedcreator-1.7.2-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

php-feedcreator-1.7.2-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

php-feedcreator-1.7.2-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.