Bug 492773
| Summary: | Review Request: camcardsync - tool for copying photos from a camera card | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zarko (grof) <zarko.pintar> | ||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting | ||||
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.1.1-2.fc11 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-04-27 13:46:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Zarko (grof)
2009-03-29 13:07:24 UTC
bump (Removing NEEDSPONSOR) Created attachment 340167 [details] Patch to compile with g++44 Some notes: * Summary - Including the name of the package into Summary * License - For this package the license tag should be GPLv2+. * BR - "BuildRequires: glib2-devel" is redundant because gtk2-devel requires glib2-devel - build.log says: --------------------------------------------------------- 225 checking for HAL... no --------------------------------------------------------- It seems this can be enabled by "BR: hal-devel". * %description - I don't think including sentences like --------------------------------------------------------- * My camera has a 2GB card and thus will frequently contain photographs spanning several weeks, or even months. --------------------------------------------------------- or so is proper, because these sentences look like personal comments or so. * Build failure - This package does not build on dist-f11-updates-candidate (with g++44). The attached patch is needed. * scriplets - Please update GTK icon cache related scripts: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache OK, thanks on review... I'm now a little slow in my process to applying suggestion. But I will very soon. regards, Zarko > * Summary > * License > * BR > * %description > * Build failure > * scriplets All resolved: SPEC: http://wiki.open.hr/~zpintar/fedora-11/SPECS/camcardsync.spec SRPM: http://wiki.open.hr/~zpintar/fedora-11/SRPMS/camcardsync-0.1.1-2.fc11.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1310790 http://koji.fedoraproject.org/koji/taskinfo?taskID=1310779 http://koji.fedoraproject.org/koji/taskinfo?taskID=1310738 Well, - I still think that including "I" in %description is not good, like -------------------------------------------------------------- * For speed and efficiency, "I" don't want to have to view the images, even in thumbnail form, to figure out which ones need copying. -------------------------------------------------------------- If you want to include this sentence in %descript, at least "I" should be changed to "you". Once %description is cleaned up, I would approve this package. OK, I changed description text, and I hope that it will be good, now. SPEC: http://wiki.open.hr/~zpintar/fedora-11/SPECS/camcardsync.spec SRPM: http://wiki.open.hr/~zpintar/fedora-11/SRPMS/camcardsync-0.1.1-2.fc10.src.rpm Okay. ----------------------------------------------------------- This package (camcardsync) is APPROVED by mtasaka ----------------------------------------------------------- New Package CVS Request ======================= Package Name: camcardsync Short Description: tool for copying photos from a camera card Owners: grof Branches: F-9 F-10 F-11 InitialCC: grof cvs done. camcardsync-0.1.1-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/camcardsync-0.1.1-2.fc9 camcardsync-0.1.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/camcardsync-0.1.1-2.fc10 camcardsync-0.1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/camcardsync-0.1.1-2.fc11 camcardsync-0.1.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. camcardsync-0.1.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. camcardsync-0.1.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |