Bug 492797
Summary: | Review Request: ofl-goudy-bookletter-1911-fonts - Clean serif font based on Kennerly Old Style | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, fonts-bugs, notting |
Target Milestone: | --- | Flags: | nicolas.mailhot:
fedora-review+
tcallawa: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-04-01 21:17:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tom "spot" Callaway
2009-03-29 18:53:50 UTC
Initial review: 1. please use "oflb" not "ofl" as prefix, since OFL is already commonly used to identify a license the Open Font Library folks use OFLB to designate themselves 2. you have the wrong font name in your fontconfig file 3. you have some stray %defines, we're supposed to use %globals nowadays 4. %common_desc is not really useful for anything in a mono-font spec file, though I suppose it's harmless 5. your metadata declaration order is unusual, though it'll probably only annoy people diffing spec files Nothing too difficult to fix for an experienced packager, and only 1 and 2 dangerous. Thank you for continuing to add fonts to Fedora. Four out of five fixed: New Spec URL: http://www.auroralinux.org/people/spot/review/new/oflb-goudy-bookletter-1911-fonts.spec New SRPM URL: http://www.auroralinux.org/people/spot/review/new/oflb-goudy-bookletter-1911-fonts-20080206-2.fc11.src.rpm This one is a go ⬬⬬⬬ APPROVED ⬬⬬⬬ You can now continue on from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a New Package CVS Request ======================= Package Name: oflb-goudy-bookletter-1911-fonts Short Description: Clean serif font based on Kennerly Old Style Owners: spot Branches: F-9 F-10 devel InitialCC: fonts-sig ... and it's done. I branched it for F-9 and F-10, but it would not build for either target because the versions of fontforge on those branches does not have support for the python extensions (rawhide does). It is built in rawhide. |