Bug 492927

It's only 'pre-review' since I can't be a sponsor.

1) license should be 'GPLv3+' (according to headers in source files)

2) why do you use 'pre-release' Release tag? consider changing 0.1 -> 1
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release

3) consider writing more detailed description

4) preserving timestamps: your Makefile must preserve timestamps using 'install -p'
http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 

5) your package doesn't own the directory '%{_datadir}/xcowsay/', see
http://fedoraproject.org/wiki/Packaging/UnownedDirectories

6) note about desktop file:
MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.

7) consider adding man pages describing other binaries than xcowsay: xcowdream, xcowthink etc.

Good luck!

Thanks a lot

I modified the spec according to your advice :
Spec URL: http://www.bde.espci.fr/~george27/xcowsay.spec
SRPM URL: http://www.bde.espci.fr/~george27/xcowsay-1.1-1.fc11.src.rpm

For point 6, I only create a .desktop file for xcowfortune since the others need an argument (the message, or the image, to display)

Some notes:

* SourceURL
  - Please consider to use %{version} macro on %SOURCE0.
    In this way you probably won't have to rewrite Source0
    when version is upgraded:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* BuildRequires
  - "BR: dbus-devel" is redundant because dbus-glib-devel has
    "Requires: dbus-devel".

* Documents
  - "INSTALL" file is usually for people who want to build/compile
    packages by themselves and not needed for rpm users
  - And "ABOUT-NLS" is almost no related to this package (this
    shows general information for translating).

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on my wiki page:
http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets
(Check "No one is reviewing")

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

I have updated the package :

Spec URL: http://www.bde.espci.fr/~george27/xcowsay.spec
SRPM URL: http://www.bde.espci.fr/~george27/xcowsay-1.1-1.fc11.src.rpm

But I have a question about the files section : Are we allowed (encouraged ?) to not include all files that we don't think it is necessary ? 

I will take a look on review Guidelines. Thank you for this advice.

Now this package itself is okay. So as I wrote in comment 3,
I will wait for your another review request or your pre-review
of other person's review request.

(In reply to comment #4)
> But I have a question about the files section : Are we allowed (encouraged ?)
> to not include all files that we don't think it is necessary ? 

Yes. Removing unneeded files is always recommended (here it doesn't mean
that unneeded files should be removed from the source tarball
itself)

By the way from next time please change the release number
every time you modify your spec file to aviod confusion.

(In reply to comment #6)
> By the way from next time please change the release number
> every time you modify your spec file to aviod confusion.  

Of course :/ sorry !

I discover an interesting package in review request, so I start a pre-review : https://bugzilla.redhat.com/show_bug.cgi?id=498246

I think I need more time to read review done by others people to understand some points.

Okay.
- Your pre-review seems good for initial comments
- This package itself is okay.
 _____________________________________ 
< This package is approved by mtasaka >
 ------------------------------------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
After you request for sponsorship a mail will be sent to sponsor 
members automatically (which is invisible for you) which notifies 
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 9/10/11, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

(In reply to comment #8)
> Okay.
> - Your pre-review seems good for initial comments
> - This package itself is okay.
>  _____________________________________ 
> < This package is approved by mtasaka >
>  ------------------------------------- 
>         \   ^__^
>          \  (oo)\_______
>             (__)\       )\/\
>                 ||----w |
>                 ||     ||
>

Thanks :) 

> Please follow the procedure written on:
> http://fedoraproject.org/wiki/PackageMaintainers/Join
> from "Get a Fedora Account".
> After you request for sponsorship a mail will be sent to sponsor 
> members automatically (which is invisible for you) which notifies 
> that you need a sponsor. After that, please also write on
> this bug for confirmation that you requested for sponsorship and
> your FAS (Fedora Account System) name. Then I will sponsor you.

I apply to the packager group.

> If you want to import this package into Fedora 9/10/11, you also have
> to look at
> http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
> (after once you rebuilt this package on koji Fedora rebuilding system).

I will take a look at this tomorrow.

> If you have questions, please ask me.

Thanks again for helping and sponsoring me.

(In reply to comment #9)

> > Please follow the procedure written on:
> > http://fedoraproject.org/wiki/PackageMaintainers/Join
> > from "Get a Fedora Account".
> > After you request for sponsorship a mail will be sent to sponsor 
> > members automatically (which is invisible for you) which notifies 
> > that you need a sponsor. After that, please also write on
> > this bug for confirmation that you requested for sponsorship and
> > your FAS (Fedora Account System) name. Then I will sponsor you.
> 
> I apply to the packager group.
> 

Sorry, I forgot to give my login : It is manawy.

(In reply to comment #10)
> Sorry, I forgot to give my login : It is manawy.  

Well, the email used in your account on FAS differs from
what is used on this bugzilla, which must coincide.
Please change either of them, then I will sponsor you.

(In reply to comment #11)
> (In reply to comment #10)
> > Sorry, I forgot to give my login : It is manawy.  
> 
> Well, the email used in your account on FAS differs from
> what is used on this bugzilla, which must coincide.
> Please change either of them, then I will sponsor you.  

Sorry, I didn't pay attention to that point. (too many e-mails !)

So :
Account name : manawy
Email : fabien.georget*at*gmail.com

Okay, now I am sponsoring you. Please follow
"Join" wiki again.

New Package CVS Request
=======================
Package Name: xcowsay
Short Description: xcowsay displays a cute cow and message on your desktop 
Owners: manawy
Branches: F-10 F-11
InitialCC:

cvs done.

xcowsay-1.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/xcowsay-1.1-1.fc11

xcowsay-1.1-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/xcowsay-1.1-1.fc10

xcowsay-1.1-1.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xcowsay'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4255

xcowsay-1.1-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xcowsay'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4473

Now closing.

xcowsay-1.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

xcowsay-1.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.