Bug 493001
| Summary: | Review Request: imgtarget - ImgTarget is a front-end to functionality provided by ArgyllCMS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zarko (grof) <zarko.pintar> | ||||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting | ||||||
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 0.1.4-3.fc9 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2009-05-18 12:02:16 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Zarko (grof)
2009-03-31 08:24:31 UTC
bump! (Removing NEEDSPONSOR) Please, wait with this until I'll resolve GCC4.4 issue and other spec cleaning. Created attachment 343228 [details]
Patch to compile with g++44
ping? Anyway:
- Patch to compile with g++44 is attached
- After this patch, build.log says:
--------------------------------------------------
checking for pnm_readpaminit in -lpnm... no
checking for pnm_readpaminit in -lnetpbm... no
--------------------------------------------------
Perhaps BR: netpbm-devel should be added
- Please update GTK cache updating scriptlets
- BR: glib2-devel is redundant as gtk2-devel requires
this
Ok, Ok... :) Sorry on my delay... two reasons: 1) My kids and I got sick 2) Much works on MLT and KDenlive at RPM fusion New spec and src: Spec URL: http://wiki.open.hr/~zpintar/fedora10/SPECS/imgtarget.spec SRPM URL: http://wiki.open.hr/~zpintar/fedora10/SRPMS/imgtarget-0.1.4-2.fc11.src.rpm Here is the Koji out: http://koji.fedoraproject.org/koji/taskinfo?taskID=1347218 After adding BR: netpbm-devel, I got this in build.log: -------------------------------------------------- checking for pnm_readpaminit in -lpnm... no checking for pnm_readpaminit in -lnetpbm... yes -------------------------------------------------- Is that OK? Assigning. Will do full review later. (In reply to comment #6) > After adding BR: netpbm-devel, I got this in build.log: > -------------------------------------------------- > checking for pnm_readpaminit in -lpnm... no > checking for pnm_readpaminit in -lnetpbm... yes > -------------------------------------------------- > > Is that OK? - This is okay Created attachment 343484 [details]
gdb log when imgtarget hangs up
For 0.1.4-2
* repeating name in Summary
- Fedora now considers that repeating software's name in
Summary (for this srpm "ImgTarget is a") is just redundant.
* License
- For this package the license tag should be
"GPLv2+".
* Timestamps
- Please use
---------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------------------
to keep timestamps on installed files.
This method usually works for Makefiles generated by
recent autotools.
* Hang up
- Well, on F-11, when
* Using GNOME desktop environment
* "Assistive support" is enabled
* launch imgtarget
* choose "Edit -> Preferences"
Then imgtarget hangs up. gdb log is attached.
Currently I have no idea how to fix this :/
(In reply to comment #8) > > * Hang up > - Well, on F-11, when > * Using GNOME desktop environment > * "Assistive support" is enabled > * launch imgtarget > * choose "Edit -> Preferences" > Then imgtarget hangs up. gdb log is attached. > Currently I have no idea how to fix this :/ Hmm, not good.... I'll report this issue (and your logfile) to upstream, so we can wait for author's reply. Until that, I'll resolve other things in your review... Here is the new revision: http://wiki.open.hr/~zpintar/fedora10/SPECS/imgtarget.spec http://wiki.open.hr/~zpintar/fedora10/SRPMS/imgtarget-0.1.4-3.fc11.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1351881 Author made some workaround for avoid crashing via dialogs.patch, so please can you test them. I do not have F11 with GNOME installed. Of course, I accepted your other review comments. Yeah, the applied patch seems to work. ---------------------------------------------------- This package (imgtarget) is APPROVED by mtasaka ---------------------------------------------------- New Package CVS Request ======================= Package Name: imgtarget Short Description: Front-end to functionality provided by ArgyllCMS Owners: grof Branches: F-9 F-10 F-11 InitialCC: grof cvs done. imgtarget-0.1.4-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/imgtarget-0.1.4-3.fc10 imgtarget-0.1.4-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/imgtarget-0.1.4-3.fc11 imgtarget-0.1.4-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. imgtarget-0.1.4-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. imgtarget-0.1.4-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |