Bug 493109 (CVE-2009-1171)

Summary: CVE-2009-1171 moodle: file disclosure flaw in TeX filter
Product: [Other] Security Response Reporter: Tomas Hoger <thoger>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: gwync
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-16 07:09:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Tomas Hoger 2009-03-31 16:48:02 UTC
CVE-2009-1171:
The TeX filter in Moodle 1.6 before 1.6.9+, 1.7 before 1.7.7+, 1.8
before 1.8.9, and 1.9 before 1.9.5 allows user-assisted attackers to
read arbitrary files via an input command in a "$$" sequence, which
causes LaTeX to include the contents of the file. 

Upstream bug and CVS commit:
http://tracker.moodle.org/browse/MDL-18552
http://cvs.moodle.org/moodle/filter/tex/filter.php?r1=1.18.4.4&r2=1.18.4.5

References:
http://www.securityfocus.com/archive/1/archive/1/502231/100/0/threaded
http://www.securityfocus.com/bid/34278
http://www.milw0rm.com/exploits/8297

Comment 1 Tomas Hoger 2009-03-31 16:49:43 UTC
Jon, I have not checked if we may be disabling TeX filter by default, but we do not ship mimetex, so we should be using system LaTex.

Comment 2 Tomas Hoger 2009-04-01 06:54:42 UTC
Upstream further reported that the above patch is not sufficient and following change should be used instead:

For >=1.9.0:
http://git.catalyst.net.nz/gw?p=moodle-r2.git;a=commitdiff;h=b950f126018a9e16a298d278375a0eedf791e5dd

For 1.6.* - 1.8.*:
http://git.catalyst.net.nz/gw?p=moodle-r2.git;a=commitdiff;h=cc9bf1486e7ea9e8cda1e4522b96e07245459a0d

Comment 3 Gwyn Ciesla 2009-04-01 14:39:06 UTC
I'm having trouble applying this.  It looks like this patch might be applied after the previous one.  Should I apply both in order or drop the portions affecting the previous patch?

Comment 4 Tomas Hoger 2009-04-01 14:58:32 UTC
CVS commit referenced in comment #0 introduced blacklist in filter.php.  Git commit in comment #2 reverts that previous commit and moves blacklist to lib.php instead.  Same change is in upstream CVS too, but it's just bit more annoying to refer to single commit changing multiple files in CVS.

Comment 5 Fedora Update System 2009-04-01 20:14:51 UTC
moodle-1.9.4-6.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/moodle-1.9.4-6.fc9

Comment 6 Fedora Update System 2009-04-01 20:14:56 UTC
moodle-1.9.4-6.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/moodle-1.9.4-6.fc10

Comment 7 Fedora Update System 2009-04-02 17:21:27 UTC
moodle-1.9.4-6.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-04-02 17:21:39 UTC
moodle-1.9.4-6.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Gwyn Ciesla 2009-04-03 12:07:11 UTC
Built for EPEL, epel_signers-members emaild to request push ASAP.