Bug 493638
Summary: | Review Request: kcometen4 - An OpenGL screensaver with exploding comets for KDE4 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | nucleo <alekcejk> |
Component: | Package Review | Assignee: | Armin <feng.shaun> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, feng.shaun, notting, rdieter |
Target Milestone: | --- | Flags: | feng.shaun:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.0.4-2.fc9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-04-22 01:02:43 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
nucleo
2009-04-02 13:30:26 UTC
I won't mention the things that are okay. MUST: MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] NOT_DONE MUST: Each package must consistently use macros. (see line 34 and 38, $RPM_BUILD_ROOT ond ${RPM_BUILD_ROOT} SHOULD: nothing (yet) I will continue the rest of the review tomorrow. It's not complete yet. (In reply to comment #1) > MUST: The spec file MUST handle locales properly. This is done by using the > %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] NOT_DONE This package doesn't includes any translations files in %{_datadir}/locale/* %find_lang is useless in this package. http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files > MUST: Each package must consistently use macros. (see line 34 and 38, > $RPM_BUILD_ROOT ond ${RPM_BUILD_ROOT} This style of defining the rpm Build Root can be used. http://fedoraproject.org/wiki/Packaging /Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS Yes, this package meets all the criteria. builds just fine in koji and no rpmlint errors. Good job. I will ask rdieter to double check it (since it's my first time), but I would approve it :) > I won't mention the things that are okay.
In many cases, it is worth mentioning, esp some important ones like mentioning
licensing checks/audits, source checksums, scriptlets, rpmlint output...
Otherwise nucleo is right (wrt locales), but for buildroot consistency, use the
same buildroot reference, ie, dont' use ${RPM_BUILD_ROOT} in one place and
$RPM_BUILD_ROOT in another.
Otherwise, looks good.
(In reply to comment #1) > MUST: Each package must consistently use macros. (see line 34 and 38, > $RPM_BUILD_ROOT ond ${RPM_BUILD_ROOT} (In reply to comment #4) > but for buildroot consistency, use the > same buildroot reference, ie, dont' use ${RPM_BUILD_ROOT} in one place and > $RPM_BUILD_ROOT in another. - fixed Build Root New Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/kcometen4/kcometen4.spec New SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/kcometen4/kcometen4-1.0.4-2.fc10.src.rpm Approved. Waiting to install this kss :) (In reply to comment #6) > Approved. Waiting to install this kss :) Thank you for review. New Package CVS Request ======================= Package Name: kcometen4 Short Description: An OpenGL screensaver with exploding comets for KDE4 Owners: nucleo Branches: F-9 F-10 F-11 InitialCC: New Package CVS Request ======================= Package Name: kcometen4 Short Description: An OpenGL screensaver with exploding comets for KDE4 Owners: nucleo Branches: F-9 F-10 InitialCC: cvs done. kcometen4-1.0.4-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/kcometen4-1.0.4-2.fc10 kcometen4-1.0.4-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/kcometen4-1.0.4-2.fc9 kcometen4-1.0.4-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kcometen4'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3626 kcometen4-1.0.4-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update kcometen4'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3630 kcometen4-1.0.4-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. kcometen4-1.0.4-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |