Bug 493802

Summary: [RFE] Providing support for ssh enabled RSA II fence devices
Product: Red Hat Enterprise Linux 5 Reporter: Marek Grac <mgrac>
Component: cmanAssignee: Marek Grac <mgrac>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: low Docs Contact:
Priority: low    
Version: 5.4CC: cfeist, cluster-maint, cward, djansa, edamato, mgrac, mhuth, pep, rlerch, tao
Target Milestone: rcKeywords: FutureFeature, Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: cman-2.0.115-1.el5 Doc Type: Enhancement
Doc Text:
Cause: Fence agent does not work when used with ssh Consequences: User have to use telnet connection which is not secure enough Fix: Fence agent was rewritten and ported to use fencing library Result: User can use secure connection to fence device
Story Points: ---
Clone Of: 476161 Environment:
Last Closed: 2009-09-02 11:10:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 476161    
Bug Blocks:    
Attachments:
Description Flags
Fence agent for RSA II
none
Patch to fencing agent included in bugzilla none

Comment 1 Marek Grac 2009-04-03 07:59:24 UTC
Created attachment 337995 [details]
Fence agent for RSA II 

Contains support for ssh, built on fencing library

Comment 5 Marek Grac 2009-05-25 12:16:17 UTC
Release note added. If any revisions are required, please set the 
"requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly.
All revisions will be proofread by the Engineering Content Services team.

New Contents:
Cause: Fence agent does not work when used with ssh
Consequences: User have to use telnet connection which is not secure enough
Fix: Fence agent was rewritten and ported to use fencing library
Result: User can use secure connection to fence device

Comment 6 Chris Ward 2009-07-03 18:28:52 UTC
~~ Attention - RHEL 5.4 Beta Released! ~~

RHEL 5.4 Beta has been released! There should be a fix present in the Beta release that addresses this particular request. Please test and report back results here, at your earliest convenience. RHEL 5.4 General Availability release is just around the corner!

If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity.

Please do not flip the bug status to VERIFIED. Only post your verification results, and if available, update Verified field with the appropriate value.

Questions can be posted to this bug or your customer or partner representative.

Comment 8 Josep 'Pep' Turro Mauri 2009-08-03 12:23:01 UTC
Customer tried this change as part of 5.4 beta tests and here are the results:

1) These lines fail:

    11 sys.path.append("@FENCEAGENTSLIBDIR@")
    12 from fencing import *

other fencing agents have:

sys.path.append("/usr/lib/fence")

With that change, the fence agent progresses further

2) Another failure happens here:

    46         atexit.register(atexit_handler)

Comment #10 in bug 476161 seems to suggest this line should not be there, so I asked the customer to remove it and keep testing from there on.

Regards,

pep

Comment 9 Marek Grac 2009-08-03 12:38:53 UTC
Created attachment 356015 [details]
Patch to fencing agent included in bugzilla

Comment 11 Issue Tracker 2009-08-04 12:40:35 UTC
Event posted on 2009-08-04 14:40 CEST by jturro

Customer tested fence_rsa patched with the patch in comment #9 and found
another problem:

[root@node1 ~] fence_node node2
agent "fence_rsa" reports: Traceback (most recent call last):
 File "/sbin/fence_rsa", line 77, in ?
   main()
 File "/sbin/fence_rsa", line 63, in main
   fence_action(conn, options, set_power_status, get_power_status, None)
TypeError: fence_action() takes exactly 4 arguments agent "fence_rsa"
reports: (5 given)

Based on other fence agents's code I suggested the following additional
change:

--- ./fence_rsa.orig	2009-08-04 12:34:30.000000000 -0400
+++ ./fence_rsa	2009-08-04 12:34:42.000000000 -0400
@@ -60,7 +60,7 @@ def main():
 	## Operate the fencing device
 	######
 	conn = fence_login(options)
-	fence_action(conn, options, set_power_status, get_power_status, None)
+	fence_action(conn, options, set_power_status, get_power_status)
 
 	##
 	## Logout from system

customer will likely test again with this change, subject to time
constrains and other test needs.

Are you aware of any additional expected change coming from differences in
the branches?

Thanks,

pep



This event sent from IssueTracker by jturro 
 issue 275549

Comment 13 Marek Grac 2009-08-05 10:13:50 UTC
Proposed patch is correct, there should be no more problems.

Comment 16 Nate Straz 2009-08-05 20:15:10 UTC
Verified that fence_rsa agent works in cman-2.0.115-1.el5.

Comment 18 errata-xmlrpc 2009-09-02 11:10:11 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1341.html