Bug 494195

Note the music package review is bug 494197, and the subtitle package review is bug 494199.

Hans,
I've already packaged drascula:
https://bugzilla.redhat.com/show_bug.cgi?id=465694
https://admin.fedoraproject.org/pkgdb/packages/name/drascula

Well, as Ralf pointed out, the readme.txt file says:

 3) You may not charge a fee for the game itself. This includes reselling the
game as an individual item.

I think this is definitely non-free and not permittable
on Fedora.

(In reply to comment #2)
> Hans,
> I've already packaged drascula:
> https://bugzilla.redhat.com/show_bug.cgi?id=465694
> https://admin.fedoraproject.org/pkgdb/packages/name/drascula  

Oh, suck. I did do a bugzilla search for drascula and that returned nothing.
Still does not return your review request, so the default search box only searches for open requests <sigh>.

Ah well, I'll close this as a dup of your drascula package.

Can you make 2 changes to your package? :

1) Add the following to the description:
"Notice that music for the game is available as an addon in the separate
drascula-music package. As are Spanish, German, French and Italian subtitles
in the drascula-international package."

(Those are the other 2 drascula packages I did, which luckily seem to
 still be valid).

2) Remove drascula.dat from the package, since scummvm-0.12.0 the
.dat files are shipped to-gether with scummvm. Yes this is not
documented very well.


p.s.

I would appreciate a review of the 2 add on packages, they are quite simple.

*** This bug has been marked as a duplicate of bug 465694 ***

(In reply to comment #3)
> Well, as Ralf pointed out, the readme.txt file says:
> 
>  3) You may not charge a fee for the game itself. This includes reselling the
> game as an individual item.
> 
> I think this is definitely non-free and not permittable
> on Fedora.  

The readme.txt contains the *exact* same license text as many other
games set free in cooperation between the original right holders and
the scummvm project, and this license has been approved for Fedora,
see:
http://www.redhat.com/archives/fedora-extras-list/2006-November/msg00020.html

(In reply to comment #4)

> Can you make 2 changes to your package? :
> 
> 1) Add the following to the description:
> "Notice that music for the game is available as an addon in the separate
> drascula-music package. As are Spanish, German, French and Italian subtitles
> in the drascula-international package."
I've added the music pack to the main package. Game seems incomplete without it
(eg. description Piano Playing). The music pack enlarges the main package with
~30M I could probably remove it but I do not like users installing 2 separate
packages.

> 2) Remove drascula.dat from the package, since scummvm-0.12.0 the
> .dat files are shipped to-gether with scummvm. Yes this is not
> documented very well.
will do.

(In reply to comment #6)
> (In reply to comment #4)
> 
> > Can you make 2 changes to your package? :
> > 
> > 1) Add the following to the description:
> > "Notice that music for the game is available as an addon in the separate
> > drascula-music package. As are Spanish, German, French and Italian subtitles
> > in the drascula-international package."
> I've added the music pack to the main package. Game seems incomplete without it
> (eg. description Piano Playing). The music pack enlarges the main package with
> ~30M I could probably remove it but I do not like users installing 2 separate
> packages.
> 

Oh, I didn't know you included the music in the main package, I personally
would like to see this split, for example on the games live dvd we are short
on space and thus do not install any of the -music packages. Also this seems the right thing to me as two seperate upstream tarbals should be 2 separate packages, so that if one of them changes the user does not need to redownload the other (unchanged) package.

> > 2) Remove drascula.dat from the package, since scummvm-0.12.0 the
> > .dat files are shipped to-gether with scummvm. Yes this is not
> > documented very well.
> will do.  

Thanks.