Bug 494197
| Summary: | Review Request: drascula-music - Background music for Drascula: The Vampire Strikes Back | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | Package Review | Assignee: | Felix Kaechele <felix> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, felix, lucilanga, notting |
| Target Milestone: | --- | Flags: | felix:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-18 09:28:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 494195 | ||
| Bug Blocks: | |||
|
Description
Hans de Goede
2009-04-05 14:32:52 UTC
$ cat cvs/pkgs/drascula/devel/sources fe2ee0948159c3acb923c89a1af7cc84 drascula-1.0.zip cde1c1509cd8af5b1dcbdcf6289b3a99 drascula-audio-1.0.zip (In reply to comment #1) > $ cat cvs/pkgs/drascula/devel/sources > fe2ee0948159c3acb923c89a1af7cc84 drascula-1.0.zip > cde1c1509cd8af5b1dcbdcf6289b3a99 drascula-audio-1.0.zip Oh, thanks for letting me know. I'm currently discussing with the drascula maintainer on whether to split drascula (seems the right thing to me two seperate upstream tarbals should be 2 separate packages). Or close this as a dup. drascula-audio has been removed from main drascula package. (In reply to comment #3) > drascula-audio has been removed from main drascula package. Thanks, Felix can you continue / restart the review then please ? The following items have been checked and are ok:
1. rpmlint is silent
2. package name complies to guidelines
3. package meets packaging guidelines
4. sha1sums match:
[felix@polaris SOURCES]$ sha1sum drascula-audio-1.0.zip*
6618ebe2f08f94836262bc68de6022f9d8f9b081 drascula-audio-1.0.zip
6618ebe2f08f94836262bc68de6022f9d8f9b081 drascula-audio-1.0.zip.orig
5. the spec file is really simple and legible even by my 80-year old grandma
6. the package builds great because it's noarch :-)
7. Requires and BuildReqs are sane
8. file ownership is ok
9. macro usage is reasonable
10. package contains content
11. doesn't own stuff it shouldn't own
The following items need to be addressed:
1. Is this really GPLv2+? the readme doesn't state so. Maybe the same mistake as in the drascula-international package?
(In reply to comment #5) > > The following items need to be addressed: > 1. Is this really GPLv2+? the readme doesn't state so. Maybe the same mistake > as in the drascula-international package? Ack, same mistake as drascula-international package, should have checked that while I was at it, sorry. Here is a new version with this fixed: Spec URL: http://people.atrpms.net/~hdegoede/drascula-music.spec SRPM URL: http://people.atrpms.net/~hdegoede/drascula-music-1.0-2.fc11.src.rpm Great! This package is APPROVED then as well. New Package CVS Request ======================= Package Name: drascula-music Short Description: Background music for Drascula: The Vampire Strikes Back Owners: jwrdegoede Branches: F-11 InitialCC: cvs done. (In reply to comment #9) > cvs done. Thanks! Imported and build, closing. |