Bug 494499

Summary: Review Request: hyphen-ta - Tamil hyphenation rules
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-08 08:18:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2009-04-07 08:12:45 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-ta.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-ta-0.20081213-1.fc10.src.rpm
Description: Tamil hyphenation rules

Comment 1 Parag AN(पराग) 2009-04-07 08:35:08 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1281836
+ rpmlint output for SRPM and for RPM is
hyphen-ta.noarch: W: no-documentation
==> can be ignored as there is no document files and license is added in hyph_ta_IN.dic
+ source files match upstream.
0626a05dcb71b96bd2f56ccfb2277cb9  hyph_ta_IN.dic
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 2 Caolan McNamara 2009-04-07 08:40:39 UTC
New Package CVS Request
=======================
Package Name: hyphen-ta
Short Description: Tamil hyphenation rules
Owners: caolanm
Branches: F-11, devel
InitialCC: caolanm

Comment 3 Kevin Fenzi 2009-04-08 02:51:58 UTC
cvs done.