Bug 494857
Summary: | Review Request: pidgin-musictracker - Pidgin displays the musictrack currently playing in your status | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jan Klepek <jan.klepek> |
Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, jon.turney, lkundrak, notting, susi.lehtola, watchman7 |
Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.4.16-1.fc10 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-05-06 23:29:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jan Klepek
2009-04-08 12:12:45 UTC
1.) Don't disable the debug package %define debug_package %{nil} 2.) Don't ship static libraries unless necessary I bet here's no use of it. Probably configure accepts --disable-static %package static ... 3.) Don't strip debugging information. See 1.) strip src/.libs/musictracker.so 4.) Please add -f here ...so that short-circuited installs work rm %{buildroot}/%{_libdir}/pidgin/musictracker.la 5.) You don't need to specify dist tag in changelog You may want to build a single spec file into multiple branches * Wed Apr 9 2009 Jan Klepek <jan.klepek> 0.4.16-1.fc10 6.) Don't call ldconfig unless you're packaging a library This DSO is just a plugin, not at the library location %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Jussi; I am going to steal this one, since I'm going to sponsor Jan. He just forgot to specify FE_NEEDSPONSOR, sorry for that. (In reply to comment #2) > Jussi; I am going to steal this one, since I'm going to sponsor Jan. He just > forgot to specify FE_NEEDSPONSOR, sorry for that. Damn, I was just about to commit the same comments as you :D No problem, I was a bit wondering about the oddness of the packaging.. Oh, dbus-devel is redundant. And you can probably drop the explicit Requires, since they should be picked up by rpm. updated spec/srpm file 1] done 2] static package removed, --disable-static used 3] when i have removed strip, rpmlint is complaining on pidgin-musictracker.i386: W: unstripped-binary-or-object /usr/lib/pidgin/musictracker.so output of rpmbuild: http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker.build.log 4] done 5] done 6] ldconfig removed dbus-devel removed from BuildRequire Jussi you mean that all Requires could be removed? updated spec/srpm available here: Spec URL: http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker.spec SRPM URL: http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker-0.4.16-1.fc10.src.rpm (In reply to comment #5) > updated spec/srpm file > 1] > done Not. You just prepended it with #, which doesn't cancel the effect of macro expansion. > 3] > when i have removed strip, rpmlint is complaining on > pidgin-musictracker.i386: W: unstripped-binary-or-object > /usr/lib/pidgin/musictracker.so See 1.) > Jussi you mean that all Requires could be removed? pcre and dbus. (See that the actual requires of built package overlap those with rpm -qp --requires You still need the explicit require of pidgin. updated spec/srpm available here: Spec URL: http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker.spec SRPM URL: http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker-0.4.16-1.fc10.src.rpm rpmlint SPECS/pidgin-musictracker.spec /home/makerpm/rpmbuild/SRPMS/pidgin-musictracker-0.4.16-1.fc10.src.rpm /home/makerpm/rpmbuild/RPMS/i386/pidgin-musictracker-0.4.16-1.fc10.i386.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. thanks Lubomir for your help *** Bug 475799 has been marked as a duplicate of this bug. *** Jan: did you check bugzilla if there was already a review request for this package? In the future, please do so before even starting to package something. [I myself have wasted a couple of hours on a few occasions working on something that has already been done.] This time it seemed that the old review was dead, so I closed it. Looks fine now. APPROVED New Package CVS Request ======================= Package Name: pidgin-musictracker Short Description: Pidgin displays the musictrack currently playing in your status Owners: hpejakle Branches: F-9 F-10 F-11 InitialCC: hpejakle cvs done. pidgin-musictracker-0.4.16-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/pidgin-musictracker-0.4.16-1.fc10 pidgin-musictracker-0.4.16-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |