Bug 495108 (CVE-2008-2025)
| Summary: | CVE-2008-2025 struts: XSS vulnerability | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Other] Security Response | Reporter: | Vincent Danen <vdanen> | ||||
| Component: | vulnerability | Assignee: | Red Hat Product Security <security-response-team> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | unspecified | CC: | dbhole, dwalluck, kreilly | ||||
| Target Milestone: | --- | Keywords: | Security | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2008-2025 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-10-19 15:36:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 506865, 506866, 506868, 506869, 506870, 523843 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Vincent Danen
2009-04-09 19:07:54 UTC
Created attachment 338986 [details]
patch taken from SUSE srpm
This patch is taken from SUSE's 10.3 struts-1.2.9-108.2.src.rpm. It applies without flaw to our RHEL5 sources.
struts-1.2.9-6.12.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/struts-1.2.9-6.12.fc9 struts-1.2.9-6.12.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/struts-1.2.9-6.12.fc10 struts-1.2.9-6.12.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/struts-1.2.9-6.12.fc11 An issue was opened upstream about this, it has a patch associated with it but it has not been committed to the upstream svn yet. https://issues.apache.org/struts/browse/STR-3191 And the proposed patch from upstream: https://issues.apache.org/struts/secure/attachment/14064/STR-3191-patch.txt According to upstream, this is a non security issue: "I think we disagree on whether this is a vulnerability in Struts or not. In my opinion the vulnerability is not in Struts code, but in any user code that uses unfiltered user input for attribute values. We have fixed XSS vulnerabilities in Struts before - but in those cases it really was a vulnerability in Struts (e.g.rendering a user input url in an error message), rather than trying to prevent dodgy user code from creating a vulnerability. Lets also put this into context - its not the normal use-case to re-render user input as attribute values - these are normally coded in the jsp page by the developer. Even where a user might want a dynamic value I believe it would be rare for this to be from user input - rather than a *safe* value controlled by the application. The most likely situation where we are re-rending user values is in the *value* of form tags and these have been filtered since Struts 1.0 Now if we had made the decision nine years ago to filter attribute values then maybe that would have been nice and helped protect users from shooting themselves in the foot - but since its worked that way for nine years it seems wrong to me to punish those users have properly filtered attribute values when required and reward those who are self harming." As a result, and because the upstream proposed changes could introduce problems where existing scripts may no longer work, we will not be correcting this in our struts packages. Future struts packages from upstream will incorporate some hardening, but to apply such hardening to existing packages may end up breaking client applications which is unacceptable for a security update. Please see https://issues.apache.org/struts/browse/STR-3191 for more information. (In reply to Vincent Danen from comment #20) > Please see https://issues.apache.org/struts/browse/STR-3191 for more > information. New URL for upstream struts bug tracker is: https://issues.apache.org/jira/browse/STR-3191 |