Bug 495219

Summary:	grubby --args modifies "module" line instead of "kernel" line
Product:	Red Hat Enterprise Linux 5	Reporter:	Karel Volný <kvolny>
Component:	mkinitrd	Assignee:	Brian Lane <bcl>
Status:	CLOSED WONTFIX	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	medium	Docs Contact:
Priority:	low
Version:	5.3	CC:	atodorov, azelinka, ddumas
Target Milestone:	rc	Keywords:	Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-03 20:16:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karel Volný 2009-04-10 14:10:39 UTC

Description of problem:
I need to automate Xen kernel configuration. For that purpose I am trying to use grubby. However, it appends the needed parameter to "modules" line instead of "kernel" line.

Version-Release number of selected component (if applicable):
mkinitrd-5.1.19.6-44

How reproducible:
always

Steps to Reproduce:
1. yum install kernel-xen
2. cp /boot/grub/grub.conf /boot/grub/grub.conf~
3. grubby --set-default=`rpm -ql kernel-xen | grep /xen.gz`
4. grubby --args="dom0_max_vcpus=1" --update-kernel=`rpm -ql kernel-xen | grep /xen.gz`
5. diff /boot/grub/grub.conf~ /boot/grub/grub.conf
  
Actual results:
10c10
< default=1
---
> default=0
17c17
<       module /vmlinuz-2.6.18-136.el5xen ro root=/dev/VolGroup00/LogVol00 console=ttyS0,115200
---
>       module /vmlinuz-2.6.18-136.el5xen ro root=/dev/VolGroup00/LogVol00 console=ttyS0,115200 dom0_max_vcpus=1


Expected results:
10c10
< default=1
---
> default=0
16c16
<       kernel /xen.gz-2.6.18-136.el5
---
>       kernel /xen.gz-2.6.18-136.el5 dom0_max_vcpus=1


Additional info:
Note also that combining --args and --set-default into one commandline does not work. However I, am not sure whether it isn't a feature rather than bug ...

Comment 4 Alexander Todorov 2010-10-18 11:28:16 UTC

qa_ack+, easy to test.

However modifying the Xen parameters vs. regular kernel parameters using a single option --args is not a good idea IMHO. We need a --xen-args parameter to distinguish between Xen parameters and regular kernel parameters.

Comment 6 RHEL Program Management 2011-01-11 20:13:04 UTC

This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated in the
current release, Red Hat is unfortunately unable to address this
request at this time. Red Hat invites you to ask your support
representative to propose this request, if appropriate and relevant,
in the next release of Red Hat Enterprise Linux.

Comment 7 RHEL Program Management 2011-01-11 23:06:19 UTC

This request was erroneously denied for the current release of
Red Hat Enterprise Linux.  The error has been fixed and this
request has been re-proposed for the current release.