Bug 495246 (perl-POE-Test-Loops)
| Summary: | Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting, steve.traylen |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/POE-Test-Loops | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-12 19:30:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2009-04-10 18:32:43 UTC
+ source files match upstream. 85a7b805542ecfae32cec5319a3d4eb8f44e1fd1 POE-Test-Loops-1.005.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1289744 + package installs properly. + rpmlint has no complaints: perl-POE-Test-Loops.src: I: checking perl-POE-Test-Loops.noarch: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(POE::Test::DondeEstan) perl(POE::Test::Loops) = 1.005 perl-POE-Test-Loops = 1.005-1.fc11 = /usr/bin/perl perl(:MODULE_COMPAT_5.10.0) perl(File::Find) perl(File::Path) perl(File::Spec) perl(Getopt::Long) perl(IO::File) perl(IO::Socket) perl(IO::Socket::INET) perl(POE) perl(POE::NFA) perl(POE::Session) perl(POE::Test::DondeEstan) perl(POE::Test::Loops) perl(POSIX) perl(Socket) perl(Symbol) perl(Test::More) perl(lib) perl(strict) perl(vars) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 + %check is present and all tests pass. All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.06 cusr 0.00 csys = 0.10 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED New Package CVS Request ======================= Package Name: perl-POE-Test-Loops Short Description: Reusable tests for POE::Loop authors Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig cvs done. Thanks for the review! :-) Package Change Request ====================== Package Name: perl-POE-Test-Loops New Branches: EL-5 Owners: stevetraylen Hi I contacted Chris a few weeks ago and he was happy for me to take perl-POE* in EPEL. Also explicitly for perl-POE-Test-Loops I asked again last week to confirm and no reply was given. Steve cvs done. |