Bug 495418
| Summary: | Review Request: python-upoints - Python modules for working with points on Earth | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Susi Lehtola <susi.lehtola> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, susi.lehtola |
| Target Milestone: | --- | Flags: | susi.lehtola:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.11.0-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-27 21:33:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-04-12 22:13:02 UTC
- Change
BR: python, python-setuptools-devel
to
BR: python-devel, python-setuptools
if you intend to branch to EPEL (EL5 has just a python-setuptools package).
- Also, you can drop the ./ in front of setup.py.
rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. ~OK
- Maybe add PKG-INFO and {NEWS,README}.html to doc?
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
APPROVED
Thanks for the review, Jussi. (In reply to comment #1) > - Change > BR: python, python-setuptools-devel > to > BR: python-devel, python-setuptools > > if you intend to branch to EPEL (EL5 has just a python-setuptools package). At the moment I have no intention to maintain this package in EPEL. Perhaps in the future. > - Also, you can drop the ./ in front of setup.py. OK, thanks for this information. New Package CVS Request ======================= Package Name: python-upoints Short Description: Python modules for working with points on Earth Owners: fab Branches: F-9 F-10 InitialCC: cvs done. python-upoints-0.11.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-upoints-0.11.0-2.fc11 python-upoints-0.11.0-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-upoints-0.11.0-2.fc10 python-upoints-0.11.0-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/python-upoints-0.11.0-2.fc9 python-upoints-0.11.0-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-upoints'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3757 python-upoints-0.11.0-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update python-upoints'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3778 python-upoints-0.11.0-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. python-upoints-0.11.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. python-upoints-0.11.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |