Bug 495420
| Summary: | Review Request: rapid-photo-downloader - Images downloader for external devices | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Felix Kaechele <felix> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, felix, notting |
| Target Milestone: | --- | Flags: | felix:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.0.8-3.b7.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-15 23:30:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-04-12 22:20:21 UTC
notify-python was added as a requirement. Spec URL: http://fab.fedorapeople.org/packages/SRPMS/rapid-photo-downloader.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/rapid-photo-downloader-0.0.8-2.b7.fc10.src.rpm So here's my review:
Here's what I checked and what is OK:
source files match upstream:
41d7fb2afe921ec82e040773757d0b1c6257285c rapid-photo-downloader-0.0.8~b7.tar.gz
41d7fb2afe921ec82e040773757d0b1c6257285c ../SOURCES/rapid-photo-downloader-0.0.8~b7.tar.gz
package meets naming and versioning guidelines.
specfile is properly named, is cleanly written and uses macros consistently.
dist tag is present.
build root is correct.
license is open source-compatible: GPLv2+
license text not included upstream.
latest version is being packaged.
BuildRequires are proper.
compiler flags are appropriate.
%clean is present.
package builds in mock.
package installs properly.
rpmlint is silent.
final provides and requires are sane:
[felix@polaris result]$ rpm -q --provides rapid-photo-downloader
rapid-photo-downloader = 0.0.8-2.b7.fc11
[felix@polaris result]$ rpm -q --requires rapid-photo-downloader
/usr/bin/python
gnome-python2
gnome-python2-gconf
gtk2
hicolor-icon-theme
notify-python
pyexiv2
pygtk2
python(abi) = 2.6
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
no shared libraries are added to the regular linker search paths.
owns the directories it creates.
doesn't own any directories it shouldn't.
no duplicates in %files.
file permissions are appropriate.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no headers.
no pkgconfig files.
no libtool .la droppings.
desktop files valid and installed properly.
Here's what I found what seems do need some work:
license field matches the actual license: the spec says GPLv2 but the code seems to be GPLv2+ since no specific requirements are mentioned that it is v2 only
the spec installs icons but the icon cache is not updated. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets
As soon as these problems are addressed I'll approve the package.
Felix, thanks for your time to make this review. (In reply to comment #2) > license field matches the actual license: the spec says GPLv2 but the code > seems to be GPLv2+ since no specific requirements are mentioned that it is v2 > only The license is GPLv2+ (mentioned in the source headers) > the spec installs icons but the icon cache is not updated. See > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets fixed Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/rapid-photo-downloader.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/rapid-photo-downloader-0.0.8-3.b7.fc10.src.rpm Since the errors mentioned have been fixed this Package is APPROVED by me. New Package CVS Request ======================= Package Name: rapid-photo-downloader Short Description: Images downloader for external devices Owners: fab Branches: F-9 F-10 F-11 InitialCC: cvs done. Thanks for the review and the cvs stuff. rapid-photo-downloader-0.0.8-3.b7.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/rapid-photo-downloader-0.0.8-3.b7.fc9 rapid-photo-downloader-0.0.8-3.b7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rapid-photo-downloader-0.0.8-3.b7.fc11 rapid-photo-downloader-0.0.8-3.b7.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rapid-photo-downloader-0.0.8-3.b7.fc10 rapid-photo-downloader-0.0.8-3.b7.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update rapid-photo-downloader'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3923 rapid-photo-downloader-0.0.8-3.b7.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rapid-photo-downloader'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4051 rapid-photo-downloader-0.0.8-3.b7.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rapid-photo-downloader'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4657 rapid-photo-downloader-0.0.8-3.b7.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rapid-photo-downloader-0.0.8-3.b7.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. rapid-photo-downloader-0.0.8-3.b7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |