Bug 495529

Summary: rpmlint incorrect warning for missing-lsb-keyword Default-Stop
Product: [Fedora] Fedora Reporter: Matt Domsch <matt_domsch>
Component: rpmlintAssignee: Ville Skyttä <ville.skytta>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 10CC: ingvar, manuel.wolfshant, ppisar, tmz, ville.skytta
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://refspecs.freestandards.org/LSB_4.0.0/LSB-Core-generic/LSB-Core-generic/initscrcomconv.html
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-13 20:42:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matt Domsch 2009-04-13 17:30:44 UTC
Description of problem:
rpmlint warns if the LSB section of an initscript does not contain a Default-Stop line.

http://fedoraproject.org/wiki/Packaging/SysVInitScript#.23_Default-Stop:_line
notes that this line is not required if the package is not set to start by default.

The warning should be removed.

Version-Release number of selected component (if applicable):
rpmlint-0.87-1.fc10.noarch 

How reproducible:
always

Steps to Reproduce:
1. rpmlint against a package with an initscript with no Default-Stop: line
2.
3.
  
Actual results:
see warning

Expected results:
no warning

Comment 1 Ville Skyttä 2009-04-13 20:42:46 UTC
I think the documentation cited draws wrong conclusions/interpretations from the LSB spec.  One may very well want to have a service stopped by default in some runlevels even if it is not started in any by default.  The LSB specs are quite vague too, which has resulted in rpmlint drawing its own conclusions, the one of which in effect here is that there should be no need not to have a Default-Stop in all init scripts, thus it always recommends adding one in all init scripts, even if empty.

$ rpmlint -I missing-lsb-keyword
missing-lsb-keyword:
The package contains an init script that does not contain one of the LSB init
script comment block convention keywords that are recommendable for all init
scripts.  If there is nothing to add to a keyword's value, include the keyword
in the script with an empty value.  Note that as of version 3.2, the LSB
specification does not mandate presence of any keywords.

Comment 2 Petr Pisar 2010-08-10 15:13:37 UTC
What about Required-Start and Required-Stop? I have the same problem (rpmlint-0.98-1.fc13).