Bug 495774
| Summary: | gfs_fsck segfaults while fixing 'EA leaf block type' problem. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Eduardo Damato <edamato> | ||||||||
| Component: | gfs-utils | Assignee: | Robert Peterson <rpeterso> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | urgent | ||||||||||
| Version: | 5.3 | CC: | cfeist, cward, edamato, hlawatschek, jkortus, rrottmann, tao | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | gfs-utils-0.1.20-1.el5 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | |||||||||||
| : | 510758 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2009-09-02 11:01:00 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Eduardo Damato
2009-04-14 18:21:52 UTC
Created attachment 339902 [details]
Preliminary patch
A similar problem was fixed in gfs2_fsck. This patch is a
gfs-crosswrite from the gfs2 patch. It is completely untested.
I'm waiting to get the customer's metadata so I can test it
properly to make sure it fixes the problem.
Setting NEEDINFO flag until I can get the metadata in to make sure it will fix the file system properly. Since the patch has not been run even once, it's likely to need a few changes before it ships. I do not recommend running the patch on a production machine until the testing of the patch is complete. This one seems to be bad too. Setting NEEDINFO again until I can get a clean copy. This copy of the metadata is perfect. I ran the patch I posted with comment #13 on it, and it correctly fixes the file system. I'll start the process of getting this into RHEL5 asap. The patch was pushed to the master branch of the gfs1-utils git tree, and the STABLE2, STABLE3 and RHEL5 branches of the cluster git tree for inclusion into 5.4. It was tested on system roth-01 using the customer's metadata that failed before the patch. Changing status to Modified. Created attachment 341575 [details]
Addendum patch
The previous patch forgot to actually write the changes to disk.
This was an oversight on my part, mainly because I made incorrect
assumptions based on how gfs2_fsck (from which the patch came)
operates. Hopefully this fixes it.
Thanks for the good news. The addendum patch was pushed to the master branch of the gfs1-utils git tree, and the STABLE2, STABLE3 and RHEL5 branches of the cluster git tree for inclusion into 5.4. Using customer metadata, I have determined that bug #507775 was caused by a regression introduced with this bug's patch. I have an addendum patch that corrects the problem and allows gfs_fsck to repair both sets of gfs metadata from bug #507775. I will post the addendum patch immediately and start the process of respinning this fix for all the appropriate releases. Temporarily changing the status to FAILS_QA, but I should be able to push the addendum fix today. Created attachment 350176 [details] Addendum patch for the 507775 problem. This patch fixes both sets of corrupt metadata from bug #507775. We can't commit this fix unless the blocker or exception flag is set for this bug. Chris, the flags were set when I originally did the commit for RHEL5.4, and that previous commit is defective. We can't ship a defective fix, so we really have no choice. Do I really need the exception flag? If so, I can likely get it. The addendum has been pushed now to master in gfs1-utils, and STABLE3, STABLE2, RHEL5 and RHEL54 branches of the cluster.git repository. It was tested on system roth-01. *** Bug 507775 has been marked as a duplicate of this bug. *** Requesting the exception flag. verified with gfs-utils-0.1.20-1.el5 to fully fix the filesystem, gfs_fsck has to be run twice. This applies until bug 509225 is fixed. Passed eatype test on x86_64 and ia64. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-1336.html |