Bug 496313

Summary: Duplicate verify methods in UserManager & ChannelManager
Product: [Community] Spacewalk Reporter: Jesus M. Rodriguez <jesusr>
Component: WebUIAssignee: Jesus M. Rodriguez <jesusr>
Status: CLOSED WONTFIX QA Contact: Red Hat Satellite QA List <satqe-list>
Severity: medium Docs Contact:
Priority: low    
Version: 0.6   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-22 18:35:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 456554    

Description Jesus M. Rodriguez 2009-04-17 18:41:57 UTC
UserManager has verifyChannelAdmin, verifyChannelSubscribable, verifyChannelRole
ChannelManager ALSO has verifyChannelAdmin, verifyChannelSubscribable, verifyChannelRole
and they do the same thing except ChannelManager throws an exception

Comment 1 Jesus M. Rodriguez 2009-04-17 18:43:28 UTC
PROPOSED REFACTORING
---------------------
1) make UserManager methods throw InvalidChannelRoleException
2) remove the methods from ChannelManager
3) change the folks using CHannelManager to use UserManager.
4) TEST!!!