Bug 496416

Summary: TPS smart card renewal clean-up needed
Product: [Retired] Dogtag Certificate System Reporter: Christina Fu <cfu>
Component: TPSAssignee: Christina Fu <cfu>
Status: CLOSED NOTABUG QA Contact: Chandrasekar Kannan <ckannan>
Severity: high Docs Contact:
Priority: medium    
Version: unspecifiedCC: alee, benl, jgalipea, jmagne
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-11 20:25:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 445047    
Attachments:
Description Flags
TPS smart card renewal cleanup
none
the missing parameters to make it happen
none
spec file changes
none
more error checking just to make sure TPS won't blow up. none

Description Christina Fu 2009-04-18 20:40:41 UTC
In bug https://bugzilla.redhat.com/show_bug.cgi?id=488291, the initial TPS smart card renewal code, as I stated, I ran out of time to do clean-up (memory leaks, performance improvement, etc).

Comment 1 Christina Fu 2009-04-18 20:56:39 UTC
Created attachment 340173 [details]
TPS smart card renewal cleanup

This is what I have for now.  Need to check in to move on to other urgent bugs before it's forgotten.

Comment 2 Christina Fu 2009-04-18 20:59:12 UTC
Created attachment 340174 [details]
the missing parameters to make it happen

Comment 3 Christina Fu 2009-04-18 21:02:30 UTC
Created attachment 340175 [details]
spec file changes

Comment 4 Christina Fu 2009-04-18 21:03:56 UTC
NOTE: This is all I can do for the time being.  More error checking will be needed.

Jack, please review.

Comment 5 Christina Fu 2009-04-18 22:05:00 UTC
Created attachment 340182 [details]
more error checking just to make sure TPS won't blow up.

Comment 6 Jack Magne 2009-04-18 22:12:17 UTC
Attachments (id=340182) (id=340175) (id=340174) +jmagne

For 340182, it looks like now that we have gotten rid of the potential crashes, we might still have some memory leaks to check for.

Comment 7 Christina Fu 2009-04-18 22:16:43 UTC
Yes, I do not intend to close this bug.  I need to attend to more urgent ones and I get back to tighten this up later when time allows.

[cfu@claw pki]$ svn commit
Sending        base/tps/doc/CS.cfg
Sending        base/tps/src/processor/RA_Enroll_Processor.cpp
Sending        dogtag/tps/pki-tps.spec
Transmitting file data ...
Committed revision 403.