Bug 496525
| Summary: | Review Request: tritonus - Java Sound API Implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Alexander Kurtakov <akurtako> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | akurtako, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | akurtako:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3.7-0.3.20090419cvs.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-30 02:29:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 496524 | ||
| Bug Blocks: | 492197 | ||
|
Description
Orcan Ogetbil
2009-04-19 22:17:40 UTC
I'm taking this one. Some of the non-versioned jars in /usr/lib/tritonus are copies not symlinks: -tritonus_share.jar -tritonus_core.jar -tritonus_gsm.jar -tritonus_remaining.jar Once this is fixed I'll do the formal review. Uh, I fixed it. What a messed up Makefile... Spec URL: http://oget.fedorapeople.org/review/tritonus.spec SRPM URL: http://oget.fedorapeople.org/review/tritonus-0.3.7-0.2.20090419cvs.src.rpm Changelog: 0.3.7-0.2.20090419cvs - Fix duplicate files issue Review:
OK; rpmlint shows a number of warnings. But the packager already explained them and I agree that they are not a problem.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: License is included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: Script for fetching sources is included.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
OK: BuildRequires are good
OK: No duplicate entries in %files listings.
OK: Permissions on files are good
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. Javadoc are in separate package.
OK: If a package includes something as %doc, it must not affect the runtime of the application.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
Package is APPROVED.
Thank you very much! New Package CVS Request ======================= Package Name: tritonus Short Description: Java Sound API Implementation Owners: oget Branches: F-9 F-10 F-11 InitialCC: CVS done. tritonus-0.3.7-0.3.20090419cvs.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tritonus-0.3.7-0.3.20090419cvs.fc11 tritonus-0.3.7-0.3.20090419cvs.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tritonus-0.3.7-0.3.20090419cvs.fc10 tritonus-0.3.7-0.3.20090419cvs.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tritonus-0.3.7-0.3.20090419cvs.fc9 tritonus-0.3.7-0.3.20090419cvs.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. tritonus-0.3.7-0.3.20090419cvs.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. tritonus-0.3.7-0.3.20090419cvs.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |