Bug 497663

Summary: Review Request: perl-HTML-StripScripts-Parser - XSS filter using HTML::Parser
Product: [Fedora] Fedora Reporter: Xavier Bachelot <xavier>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
dennis: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.02-1.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-06 23:26:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 497662    
Bug Blocks:    

Description Xavier Bachelot 2009-04-25 21:05:33 UTC
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-StripScripts-Parser.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-HTML-StripScripts-Parser-1.02-1.fc10.src.rpm
Description: This class provides an easy interface to HTML::StripScripts, using
HTML::Parser to parse the HTML.

Comment 1 Parag AN(पराग) 2009-04-30 08:43:32 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1330026
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0fb38dc2c632844883f3e716b056a88a  HTML-StripScripts-Parser-1.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=217,  0 wallclock secs ( 0.10 usr  0.02 sys +  0.43 cusr  0.06 csys =  0.61 CPU)
+ Package perl-HTML-StripScripts-Parser-1.02-1.fc12.noarch =>
Provides: perl(HTML::StripScripts::Parser) = 1.02
Requires: perl(HTML::Parser) perl(HTML::StripScripts) perl(base) perl(strict) perl(vars)
+ Not a GUI application

APPROVED.

Comment 2 Xavier Bachelot 2009-04-30 08:59:49 UTC
Thanks for yet another review Parag :-)

New Package CVS Request
=======================
Package Name: perl-HTML-StripScripts-Parser
Short Description: XSS filter using HTML::Parser
Owners: xavierb
Branches: F-9 F-10 F-11 EL-5
InitialCC: perl-sig

Comment 3 Dennis Gilmore 2009-05-01 20:56:38 UTC
CVS Done

Comment 4 Xavier Bachelot 2009-05-03 22:24:17 UTC
Imported and built for F-9, F10 and F-11.
Imported and built a slightly older version for EL-5 to be able to fulfil the build requirements.

Comment 5 Fedora Update System 2009-05-03 22:26:54 UTC
perl-HTML-StripScripts-Parser-1.02-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-HTML-StripScripts-Parser-1.02-1.fc10

Comment 6 Fedora Update System 2009-05-03 22:26:58 UTC
perl-HTML-StripScripts-Parser-1.02-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/perl-HTML-StripScripts-Parser-1.02-1.fc9

Comment 7 Fedora Update System 2009-05-03 22:27:03 UTC
perl-HTML-StripScripts-Parser-1.02-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-HTML-StripScripts-Parser-1.02-1.fc11

Comment 8 Fedora Update System 2009-05-06 23:26:02 UTC
perl-HTML-StripScripts-Parser-1.02-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2009-05-06 23:27:07 UTC
perl-HTML-StripScripts-Parser-1.02-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-05-09 04:04:38 UTC
perl-HTML-StripScripts-Parser-1.02-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.