Bug 497735
| Summary: | Review Request: php-ezc-Cache - eZ Components Cache | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Guillaume Kulakowski <guillaume> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 10 | CC: | fedora, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.4-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-13 00:22:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Guillaume Kulakowski
2009-04-26 16:47:41 UTC
Shouldn't you consider adding APC as a dependency ? I do not think. APC is an option of php-ezc-Cache. You can use php-ezc-Cache and have an auther opcode cache solution (like php accelerator) and is this fact, install 2 opcode cache can make conflicts. REVIEW: + rpmlint is ok php-ezc-Cache.src: I: checking php-ezc-Cache.noarch: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines (new update) + License ok : BSD + License is upstream + spec in english and legible + license file in sources is provided + sources match the upstream sources d1f3d512828f50274f62f6af82b30ad5 Cache-1.4.tgz + Source URL ok + build on F10.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation not required to run + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in mock (fedora-rawhide-x86_64) + no test suite + scriptlets ok + Final Requires ok /usr/bin/pear php-common >= 5.2.1 php-pear(components.ez.no/Base) >= 1.5 + Final Provides ok php-pear(components.ez.no/Cache) = 1.4 php-ezc-Cache = 1.4-1.fc8 SHOULD: As you remove empty (dummy) file, you can probably also remove empty dir in docdir So : rm -rf ./docdir/cache Please add a note about the use of APC for cache storage only available if php-pecl-apc extension installed (in %description). -------- APPROVED -------- New Package CVS Request ======================= Package Name: php-ezc-Cache Short Description: Provides a collection of lightweight classes to cache different kinds of data Owners: llaumgui Branches: F-9 F-10 F-11 InitialCC: cvs done. php-ezc-Cache-1.4-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/php-ezc-Cache-1.4-1.fc9 php-ezc-Cache-1.4-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-ezc-Cache-1.4-1.fc10 php-ezc-Cache-1.4-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update php-ezc-Cache'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-4160 php-ezc-Cache-1.4-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-ezc-Cache'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4215 php-ezc-Cache-1.4-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. php-ezc-Cache-1.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-ezc-Cache New Branches: EL-6 Owners: llaumgui Git done (by process-git-requests). Package Change Request ====================== Package Name: php-ezc-Cache New Branches: EL-7 Owners: llaumgui Git done (by process-git-requests). |